Skip to content

Tchain Client against devnet #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 123 commits into from
Aug 5, 2024
Merged

Conversation

AlaaElattar
Copy link
Contributor

No description provided.

@AlaaElattar AlaaElattar changed the base branch from main to main_signer_workflows November 28, 2023 08:13
@AlaaElattar AlaaElattar changed the title Tchain Tchain Client against devnet Nov 28, 2023
@AlaaElattar AlaaElattar marked this pull request as draft November 28, 2023 08:14
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: Patch coverage is 3.38189% with 5771 lines in your changes missing coverage. Please review.

Project coverage is 2.44%. Comparing base (40a917b) to head (a151814).
Report is 3 commits behind head on main.

Current head a151814 differs from pull request most recent head f8446d1

Please upload reports for the commit f8446d1 to get more accurate results.

Files Patch % Lines
...erated/dev/types/pallet_balances/pallet/event.dart 0.25% 786 Missing ⚠️
...b/generated/dev/types/pallet_dao/pallet/event.dart 0.54% 362 Missing ⚠️
...nerated/dev/types/pallet_balances/pallet/call.dart 0.59% 333 Missing ⚠️
...ated/dev/types/pallet_collective/pallet/event.dart 0.64% 307 Missing ⚠️
...rated/dev/types/pallet_collective/pallet/call.dart 0.74% 266 Missing ⚠️
.../generated/dev/types/frame_system/pallet/call.dart 0.78% 252 Missing ⚠️
...lient/lib/generated/dev/pallets/tfgrid_module.dart 1.31% 226 Missing ⚠️
...ib/generated/dev/types/pallet_dao/pallet/call.dart 1.04% 189 Missing ⚠️
...generated/dev/types/frame_system/pallet/event.dart 2.11% 185 Missing ⚠️
...nerated/dev/types/pallet_kvstore/pallet/event.dart 1.20% 164 Missing ⚠️
... and 63 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #11       +/-   ##
==========================================
- Coverage   86.36%   2.44%   -83.92%     
==========================================
  Files           1     204      +203     
  Lines          22   18137    +18115     
==========================================
+ Hits           19     444      +425     
- Misses          3   17693    +17690     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlaaElattar AlaaElattar marked this pull request as ready for review June 25, 2024 13:32
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add how to generate the types

});
test('Test Update Twin', () async {
try {
await client.twins.update(relay: "relay.qa.grid.tf".codeUnits, pk: []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may get the twin too and check if the value got updated or not

@AlaaElattar AlaaElattar marked this pull request as draft July 30, 2024 13:57
@AlaaElattar AlaaElattar marked this pull request as ready for review July 31, 2024 14:31
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 💯

@AlaaElattar AlaaElattar merged commit 3600254 into main Aug 5, 2024
2 checks passed
@AlaaElattar AlaaElattar deleted the main_signer_workflows_tfchain branch August 5, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants