Skip to content

Fix getTransactions pagination #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Fix getTransactions pagination #144

merged 3 commits into from
Apr 9, 2025

Conversation

@zaelgohary
Copy link
Collaborator

Changes

  • Fix getTransactions pagination
  • Add pagingToken to PaymentTransaction class

Related Issues

Checklist

  • Tests included
  • Build pass
  • Code format
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary requested a review from AlaaElattar April 8, 2025 08:31
AlaaElattar
AlaaElattar approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we can optimize getting memos in parallel. (we can create separate issue for it)

@zaelgohary zaelgohary requested a review from AlaaElattar April 9, 2025 05:42
AlaaElattar
AlaaElattar approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 🚀

@zaelgohary zaelgohary merged commit 0ce3b57 into development Apr 9, 2025
2 checks passed
@zaelgohary zaelgohary deleted the development_fix_transactions_pagination branch April 9, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlaaElattar AlaaElattar AlaaElattar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zaelgohary @AlaaElattar