-
Notifications
You must be signed in to change notification settings - Fork 0
add stellar client #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into main_stellar_wallet
…into main_stellar_wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation combines a service and a client. Part of it asks for the keypair to use for sending a transaction and the other part uses the loaded one. I believe we should load the account on the constructor, then we can use the loaded account to activate the account, send transactions, get balance, list transactions, ... and so on.
For creating an account, it can be a factory constructor that generates a keypair and returns a client instance.
// create new account
factory Client.create(network) {
final keyPair = KeyPair.random();
return Client(network, keyPair.secretSeed);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure that the helper methods are private
return transaction; | ||
} | ||
|
||
Future<void> submitFundedTransaction(Transaction fundedTransaction) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it sending a funded transaction or funding the transaction and sending it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funds and signs a TFT transaction.
packages/stellar_client/README.md
Outdated
|
||
Create new testnet account: | ||
|
||
- If no mnemonic provided, it will be created by the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it depends on which method is called
No description provided.