Skip to content

"americas" region returns no nodes #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottyeager opened this issue Mar 27, 2025 · 2 comments
Open

"americas" region returns no nodes #1346

scottyeager opened this issue Mar 27, 2025 · 2 comments
Assignees
Labels
grid-proxy belongs to grid proxy
Milestone

Comments

@scottyeager
Copy link

Image

@scottyeager scottyeager added the grid-proxy belongs to grid proxy label Mar 27, 2025
@Omarabdul3ziz Omarabdul3ziz self-assigned this Apr 9, 2025
@Omarabdul3ziz Omarabdul3ziz moved this to In Progress in 3.17 Apr 9, 2025
@Omarabdul3ziz
Copy link
Contributor

previously we had inconsistencies between the data sources used to get region/country and coordinates, so we unified them in this change: 0c0246a

for the region, we used the continent as a fallback since the dataset lacks a specific region field. This worked for all continents except America, where nodes were indexed as either North or South America
Image
here https://gridproxy.grid.tf/nodes?region=North%20America

The region filter used exact matching, so your request didn’t work. The mentioned PR changes this to allow subtext matching, so filtering by "America" now includes both continents.

@Omarabdul3ziz Omarabdul3ziz moved this from In Progress to Pending Review in 3.17 Apr 13, 2025
@Omarabdul3ziz Omarabdul3ziz moved this from Pending Review to In Verification in 3.17 Apr 15, 2025
@rawdaGastan rawdaGastan added this to the v0.17.x milestone Apr 16, 2025
@scottyeager
Copy link
Author

Thanks for the explanation @Omarabdul3ziz.

I should have included the fact that I expected this filter to work based on this line from the tfrobot README:

region: europe # region could be the name of the continents the nodes are located in (africa, americas, antarctic, antarctic ocean, asia, europe, oceania, polar)

Seems the README should also be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid-proxy belongs to grid proxy
Projects
Status: In Verification
Development

No branches or pull requests

3 participants