Support multiple gateway backends #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Nabil-Salah
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
|
Gateway Name deploy on zos:
Gateway Name deploy on zos light:
|
|
deploy vm zos:
deploy vm zos light:
|
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
rawdaGastan
requested changes
Apr 16, 2025
…to workload Signed-off-by: nabil salah <nabil.salah203@gmail.com>
rawdaGastan
reviewed
Apr 16, 2025
| @@ -41,7 +41,7 @@ func zlogs(dl *zosTypes.Deployment, name string) []Zlog { | |||
|
|
|||
| var dataI interface{} | |||
|
|
|||
| dataI, err := wl.Workload3().WorkloadData() | |||
| dataI, err := wl.Workload.Workload().WorkloadData() | |||
There was a problem hiding this comment.
why not only renaming here?
There was a problem hiding this comment.
it give error because embedded field Workload is shadowing the method
also it should act the same
https://go101.org/article/type-embedding.html
section: Shorthands of Selectors
rawdaGastan
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change restrictions on gateway backends count
Changes
grid-client/workloads/gateway_fqdn.goRelated Issues
Checklist