refactor region filtering #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Omarabdul3ziz
commented
Apr 13, 2025
Omarabdul3ziz
commented
- improve region filtering with case-insensitive matching in database queries
- "americas" region returns no nodes #1346
Omarabdul3ziz
requested review from
AbdelrahmanElawady,
Eslam-Nawara,
ashraffouda,
mariobassem,
rawdaGastan,
sameh-farouk and
xmonader
as code owners
xmonader
reviewed
Apr 14, 2025
| return nil | ||
| } | ||
|
|
||
| runesList := []rune(c) |
Contributor
There was a problem hiding this comment.
what does this block of code do?
xmonader
reviewed
Apr 14, 2025
| return nil | ||
| } | ||
|
|
||
| runesList := []rune(region) |
Contributor
There was a problem hiding this comment.
seems like that's also duplicated from the code above?
Contributor
Author
There was a problem hiding this comment.
yes, it is duplicated same as CityContains and CountryContains filters for both nodes/farms.
basically this snippet tries to get a substring of a random city/country/region from the aggregated values from the database, to pass it the filter and make sure it can search with any part of the value
…filters for cleaner/testable code
xmonader
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.