init messenger #1370
Open
init messenger #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omarabdul3ziz
force-pushed
the
development_messenger
branch
from
4765b05 to
88a152c
Compare
Omarabdul3ziz
force-pushed
the
development_messenger
branch
from
88a152c to
1ec1d4b
Compare
Omarabdul3ziz
force-pushed
the
development_messenger
branch
from
1ec1d4b to
52f1a26
Compare
Omarabdul3ziz
force-pushed
the
development_messenger
branch
from
c8134a0 to
dc513bd
Compare
Omarabdul3ziz
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new messenger package to support Mycelium messenger identity with features such as twin management and JSON-RPC server/client functionality. Key changes include:
- Implementation of twin management functions (GetMyceliumInfo and UpdateMyceliumTwin) to integrate chain identity.
- Addition of JSON-RPC server and client examples for distributed messaging.
- Updates to documentation, module configuration, build, and CI workflows to include the messenger package.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| messenger/twin.go | New twin management functions integrating Mycelium identity via API call and on-chain update. |
| messenger/raw.go | Added TODO for raw message handling. |
| messenger/jsonrpc.go | Comprehensive JSON-RPC implementation added. |
| messenger/go.mod | Module file updated with required dependencies. |
| messenger/examples/jsonrpc/server/main.go | Example implementation of a JSON-RPC server. |
| messenger/examples/jsonrpc/client/main.go | Example implementation of a JSON-RPC client. |
| messenger/README.md | Documentation for the new messenger package. |
| go.work, go.work.sum, README.md, Makefile, and workflows | Inclusion of messenger package in overall project build and test setup. |
Comments suppressed due to low confidence (1)
messenger/twin.go:63
- Consider renaming 'twinid' to 'twinID' to align with Go naming conventions and improve clarity.
twinid, err := c.subCon.GetTwinByPubKey([]byte(c.identity.PublicKey()))
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init mycelium messenger identity
waiting: threefoldtech/tfchain#1037