Calculator Package Refactoring and Performance Optimizations #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and certified pricing
…ch/tfgrid-sdk-go into development_refactor
…ch/tfgrid-sdk-go into development_refactor
…illing info without unbilled amount
0oM4R
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
Eslam-Nawara
reviewed
Jul 8, 2025
grid-client/calculator/calculate.go
Outdated
| if errors.Is(err, ErrContractDeleted) { | ||
| return | ||
| } | ||
| resultChain <- result{err: err} |
There was a problem hiding this comment.
you can use sync.Mutex for both adding the cost and accumulating the error, you can use multierror for example
grid-client/calculator/calculate.go
Outdated
| var totalCost int64 = 0 | ||
| errList := make([]error, 0) |
There was a problem hiding this comment.
you can use "github.com/hashicorp/go-multierror" to accumilate the error instead of a slice of errors
grid-client/calculator/calculate.go
Outdated
Comment on lines
303
to
308
| if len(errList) > 0 { | ||
| if len(errList) == 1 { | ||
| return 0, errList[0] | ||
| } | ||
| totalCost += cost | ||
| return 0, fmt.Errorf("multiple errors occurred: %v", errList) | ||
| } |
There was a problem hiding this comment.
you should not skip errors even if you have multiple ones, you need to send them back to the caller, thus using multierr is much easier
… handling in contract calculations
0oM4R
force-pushed
the
development_refactor
branch
from
11a074a to
09f9e03
Compare
rawdaGastan
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a comprehensive refactoring of the calculator package in the grid-client to improve performance, readability, and maintainability. The changes focus on optimizing contract cost calculations, simplifying pricing logic, and enhancing test coverage.
Changes
public Ipon the rented node, and on the name contractRelated Issues
Checklist