Skip to content

Rewrite profile manager dialog #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0oM4R opened this issue Jan 12, 2025 · 18 comments
Closed

Rewrite profile manager dialog #3805

0oM4R opened this issue Jan 12, 2025 · 18 comments
Assignees
Labels
type_feature New feature or request
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Jan 12, 2025

Which package/s are you suggesting this feature for?

Dashboard

Is your feature request related to a problem? Please describe

the current logic is very complex and in some cases it is unbredictable

Describe the solution you'd like

will update the issue with the changes and pattern I will follow once I check the code.

@0oM4R 0oM4R added the type_feature New feature or request label Jan 12, 2025
@0oM4R 0oM4R self-assigned this Jan 12, 2025
@ramezsaeed ramezsaeed moved this to Accepted in 3.16.x Jan 14, 2025
@ramezsaeed ramezsaeed added this to the 2.7.0 milestone Jan 14, 2025
@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 15, 2025

  • Basic issues to be resolved:

    - Replaced the conditional fields with separate tabs; this should include moving some common fields to be separate components
    - Separate the connect button and the dialog component
    - Fix the checking if the password is stored; some times it is not functional
    - Move the functions to a utils 

  • Enhancements
    
 - add skeleton loading to handle lazy loading and checking stored passwords
    

- add ids and class names to make the automated test easier and more functional

@0oM4R 0oM4R moved this from Accepted to In Progress in 3.16.x Jan 16, 2025
@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 16, 2025

Issue update:
add the Wallet_KEY to env, also on setting the stacks links will set the isSoredCredentials to env, to be globally accessible, and to avoid lazyloading related issue
working on separate the taps to a components

@0oM4R 0oM4R mentioned this issue Jan 20, 2025
15 tasks
@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 20, 2025

issue update:
completed the login tab, working on the register tab.
note: some functionality may need to be refactored; we will update the issue with those update as well

refactor: removed isStoredCredentials; it doesn't provide any benefit

@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 21, 2025

#1955

@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 21, 2025

Issue update:
(WIP): create connect wallet tab, need to add the activation and create account logic
(TODO): move T&C dialog to a separate component and revisit reload logic, #1955

Refactor: enhanced the state management of the password field by using form and formValidator, to avoid state conflict

@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 22, 2025

Issue update:
completed the create, activate and accept terms&condetinos parts
enhance relaod mnemonic validation to be enabled only if we have a valid mnemonic and got an error while getting the grid

TODO: check disable auto complete; and use the created components in profile manager component

@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 23, 2025

Issue update:

  • applied the new changes to the profile manager
  • added suspense and skeleton loader
  • enhanced the checking of stored credentials

todo: apply BEM class names, and test the flow

@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 29, 2025

issue update: test and fixed some flows, added the BEM ids Pr ready for review rn

@0oM4R 0oM4R moved this from In Progress to Pending Review in 3.16.x Jan 29, 2025
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.7.0, 2.8.0 Jan 29, 2025
@0oM4R 0oM4R moved this from Pending Review to Accepted in 3.16.x Feb 3, 2025
@amiraabouhadid
Copy link
Contributor

make sure you handle this err in old profile manager as well

Image

@0oM4R 0oM4R moved this from Accepted to In Progress in 3.16.x Feb 26, 2025
@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 26, 2025

make sure you handle this err in the old profile manager as well

Image
I tried many scenarios to reproduce that error, it is not reproducible on the pr

Image
I created an account logged in; then changed the network and refreshed
the error in the screenshot due to log.error but there is no recursive call

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 26, 2025

Issue update:

  • resolved the conflicts
  • updated the T&C logic to sync with the new changes
  • tested some cases to reproduce the mentioned errors

@0oM4R 0oM4R moved this from In Progress to Accepted in 3.16.x Mar 2, 2025
@0oM4R 0oM4R moved this from Accepted to In Progress in 3.16.x Mar 3, 2025
@0oM4R
Copy link
Contributor Author

0oM4R commented Mar 3, 2025

@0oM4R 0oM4R moved this from In Progress to Pending Review in 3.16.x Mar 3, 2025
@0oM4R
Copy link
Contributor Author

0oM4R commented Mar 16, 2025

work completed:

  • change the keypairType from auto complete to v select to avoid auto complete
  • style: add some spaces and rename the tabs to match the old style
  • always reset the active tab to login

@AhmedHanafy725 AhmedHanafy725 removed this from 3.16.x Mar 20, 2025
@AhmedHanafy725 AhmedHanafy725 moved this to Pending Review in 3.17 Mar 20, 2025
@0oM4R 0oM4R moved this from Pending Review to In Verification in 3.17 Apr 6, 2025
@ramezsaeed
Copy link
Contributor

Make sure the tabs works fine, even on mobile

@ramezsaeed
Copy link
Contributor

WIP

  • verification in progress on devnet
  • 6f50738

@khaledyoussef24
Copy link
Contributor

email field is now disabled untill user inserts menomonics

I still have some of the fields still have autofill enabled

also we may disable the autofill when retyping the password

Image Image Image Image

@0oM4R
Copy link
Contributor Author

0oM4R commented May 11, 2025

agreed to handle the confirm password field on #4108

@khaledyoussef24
Copy link
Contributor

version :2.8
network : dev
can close for now all previous requirments were handle will check the confirm password field here
#4108
and enhancing the flow in
#4109
the flow now works fine
all fields disabled untill creating mnemonics or pasting it
testcase

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.17 May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants