Allow using dash and underscore in domains

[samaradel]

Description

• Allow using dash and underscore in domains
• Update models decorators
• Replace characters in workload names
• Update Domains page and manage gateway dialog with new validators

Changes

Screencast.from.05-03-25.12.14.34.webm

Related Issues

• Support adding underscores and dashes while deploying name contract #3307

Tested Scenarios

• Add a dash or underscore in the domain
• Adding a dash and an underscore as the first/last character is not acceptable
• Add 2 or more underscores in the same domain name
• Add 2 or more dashes in the same domain name
• Combine 2 underscores and 2 dashes in the same domain name

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

• Preliminary Checks
  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

• UI Checks
  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

• Code Quality Checks
  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Testing Checklist

• Does it Meet the specified acceptance criteria.
• Test if changes can affect any other functionality.
• Tested with unit, integration, and end-to-end tests.
• Tested the un-happy path and rollback scenarios.
• Documentation updated to meet the latest changes.
• Check automated tests working successfully with the changes.
• Can be covered by automated tests.

General Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstring
• Screenshots/Video attached (needed for UI changes)

[0oM4R]

Screen.Recording.2025-03-05.at.2.23.33.PM.mov

I can't delete the domain with dash and underscore while the old domains got deleted normally

also in the details I got the workload name is that expected ?

[samaradel]

For deleting domains, I can't check atm as I added a domain from the client and it sound like it's not supported yet to show on the dashboard, so created an issue for this #3962

For the domain, it's just like what you added except the workload name. The dash is replaced as it's not supported in zos.

[amiraabouhadid]

can use underscore and dashes in subdomain name now

however the dash doesn't show in the name, only in the domain field

after deleting gateway, contract remains

I only see this in the logs
Start deleting the gateway deployment with name vm10732_vmjixu2n
even though domain is deleted from list here

[0oM4R]

Listing and deleting work fine.
but name is still exist and it is very confusing

and what if we have another domain with the same name but without the dash

[samaradel]

I think I should remove it form details (first Image) but I'm not sure about the rest
@AhmedHanafy725 what do you think?

[AhmedHanafy725]

Listing and deleting work fine. but name is still exist and it is very confusing

you can remove the name from these details

and what if we have another domain with the same name but without the dash

I didn't get what is the issue (the domain is different)

[0oM4R]

and what if we have another domain with the same name but without the dash

I didn't get what is the issue (the domain is different)

Confusing if the workload name is visible anywhere

[amiraabouhadid]

was able to create domains with dashes and underscore, validation works and checks if name exists , deletion also works, great job

[0oM4R]

I still can see the workload name after removing the dash

[ramezsaeed]

Test scenarios:

• add 2 or more underscores in the same domain name.
• add 2 or more dashes in the same domain name
• combine 2 underscores and 2 dashes in the same domain name
• test delete domains with dashes and underscore

[0oM4R]

still in domains solution

[0oM4R]

Screen.Recording.2025-04-07.at.11.49.56.AM.mov

I deployed a domain with a custom domain, but I couldn't delete it.
I think this case needs to be handled

[ramezsaeed]

Screen.Recording.2025-04-07.at.11.49.56.AM.mov
I deployed a domain with a custom domain, but I couldn't delete it. I think this case needs to be handled

I can see the domain name doesn't have dashes or underscore, why it can't be deleted!

[samaradel]

@0oM4R @ramezsaeed fixed now