Selenium Work flow enhancements #4065
Conversation
khaledyoussef24
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R and
samaradel
as code owners
| @@ -2,38 +2,77 @@ name: Playground Selenium Tests | |||
|
|
|||
| on: | |||
| workflow_dispatch: | |||
| inputs: | |||
| branch: | |||
| description: "Select which Git branch to run against" | |||
There was a problem hiding this comment.
Lets unify our messages and use the same message like grid nigtly
"Use workflow from"
| type: choice | ||
| default: "dev" | ||
| options: | ||
| - local |
There was a problem hiding this comment.
The local option will run the dashboard server on which network?
There was a problem hiding this comment.
will do a local lerna build and run locally;
and this was the originally daily night run.
but i think we don't need it anymore and better to run nightly run on staging.
what do you think ?
There was a problem hiding this comment.
ok, but it's not a network cause the local server could run against dev, qa, test, and main nets. Also, the branch option will only run the tests from this branch, but the source code will be based on the deployed website. So IMO, we should always run the server locally with the preferred network.
here is the guide to switch the network https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/docs/build.md#run-the-script
There was a problem hiding this comment.
what we can do is
keep the default nightly run install the server locally to have the same branch.
but for other networks don't see the point of that;
we can use the tests from any branch to run against any network release,
this will help us more in release actually.
but will keep your point only for nightly run on local build.
| - name: Set up Node.js 18 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
| - name: Yarn install | ||
| run: yarn install | ||
| - name: Lerna Build | ||
| run: yarn lerna run build | ||
| - name: Yarn Serve | ||
| node-version: "18" | ||
|
|
||
| - name: Install JS dependencies & build | ||
| if: ${{ github.event.inputs.network == 'local' }} | ||
| run: | | ||
| yarn install | ||
| yarn lerna run build | ||
|
|
||
| - name: Start playground server | ||
| run: make run project=playground & | ||
| - name: Wait for localhost | ||
|
|
||
| - name: Wait for server to be ready | ||
| run: sleep 60 |
There was a problem hiding this comment.
All these steps for running the local server, and only the install step has the condition if: ${{ github.event.inputs.network == 'local' }}
There was a problem hiding this comment.
yes these steps are needed only for launch the dashboard locally; instead of this in all other network we just use the dashboard URL.
There was a problem hiding this comment.
Agreed with Hanafy and Team; to add a flag to be used if want a local build against any specific network, and by default the nightly workflow will run against staging env.
|
work in progress:
|
Description
Selenium Work flow enhancements: make 'network' input a choice type for workflow_dispatch
The Selenium tests should be able to run against any of the following environments:
🐞 [Bug]: Adapt selenium workflow to take env as a variable in manual trigger for a run and better visual add test report #3755
Changes
List of changes this PR includes
Related Issues
List of related issues
Tested Scenarios
A list of scenarios tried to match the deliverables
Documentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist