-
Notifications
You must be signed in to change notification settings - Fork 8
upgrade all dependencies to latest version #4081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
* audit: @noble/secp256k1: 1.7.1 --> 2.2.3 algosdk: 1.19.0 --> 3.2.0, also update the algo module to be compatible with the new version. stellar-sdk --> @stellar/stellar-sdk v13.2.0 * audit: crypto-js
…into development_upgrades
ec1ff5d
to
8833469
Compare
About the new eslint rules, we are now using totally new versions of elsint and its plugins; so I tried as much as I can to introduce rules that are similar to the old rules, which are (many of them) not compatible with the new version. Some warnings I add to enhance code quality with warnings only ,but not all of them are breaking we have 2 options here, keep the rules as it and handle it in #4086, or disable the new rules |
<img | ||
v-else | ||
:src="countryFlagSrc" | ||
class="h-100" | ||
:alt="(node?.location.country ?? 'node') + '-flag'" | ||
v-bind="props" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removed? should be self-closing
@@ -275,7 +366,7 @@ | |||
<reserve-btn | |||
v-if="node?.dedicated && node?.status !== 'down'" | |||
class="ml-4" | |||
:node="(node as GridNode)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,6 +1,7 @@ | |||
import { Mycelium } from "../zos"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import, please remove.
import { ValidateMembers } from "../helpers"; | ||
import { WorkloadData, WorkloadDataResult } from "./workload_base"; | ||
import { WorkloadTypes } from "./workload"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used, please use it
@@ -0,0 +1,226 @@ | |||
import { Buffer } from "buffer"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used , please remove
Screencast.from.19-05-25.13.58.48.webm |
@amiraabouhadid the tests workflow is almost the same as the development branch |
…into development_upgrades
Description
Please use node ^22 lts and try to reclone the repo
Changes
Root package changes
ESLint Migration
Husky: update pre-commit script and remove deprecated command
Workflow
Playground changes
$vuetify
theme with use thememarked
package upgradecontains
from cider-tools withcontainsCidr
upgrade compatibilityGridclient changes
Stellar Module Enhancements
Primitives and Modules
ZOS
Tests: - as I mentioned before assigning mycelium or any other property that have type will give an error while class transformation, this applied on machine, machine light, network light, workloads
TFChain Client Updates
Upgrades
Root Package Dependencies
graphql_client
grid_client
grid_http_server
grid_rmb_server
gridproxy_client
monitoring
playground
rmb_direct_client
rmb_peer_client
rmb_peer_server
stats
stellar_solana_bridge
tfchain_client
types
please note that some packages are not on the latest major versions due to CJS removed build
those packages are:
Also @jimber/pkid upgrade will not help, please see threefoldtech/pkid_node_client#9
Related Issues
#2978
Tested Scenarios
please note all the failing tests are not related to this pr
Documentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist