Skip to content

Fix funkwhale solution #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

Fix funkwhale solution #4136

wants to merge 2 commits into from

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented May 15, 2025

Description

When we deploy a funkwhale instance, we can't reach the application with a bad gateway.

Changes

image

Related Issues

Tested Scenarios

  • Check if deploy is completed successfully
  • Check if the app and the VM is reachable

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

samaradel added 2 commits May 14, 2025 16:06
- Update the env keys
- Update the disk mountPoint
- Update gateway name port
- Use Name as username of the funkwhale account
>
<input-tooltip tooltip="Funkwhale admin username.">
<v-text-field label="Username" v-model="username" v-bind="props" />
<v-text-field label="Name/Username" v-model="name" v-bind="props" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be only the name, and we can add a description to the tooltip, like instance name, will be used as a username

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Email can do it too, @AhmedHanafy725, so can Email do it instead of the deployment name?

@0oM4R
Copy link
Contributor

0oM4R commented May 15, 2025

also we need to update those values

funkwhale: {
FUNKWHALE_HOSTNAME: "Funkwhale Hostname",
DJANGO_SUPERUSER_EMAIL: "Superuser Email",
DJANGO_SUPERUSER_USERNAME: "Superuser Username",
DJANGO_SUPERUSER_PASSWORD: { label: "Superuser Password", type: "password" },
},

image

@amiraabouhadid
Copy link
Contributor

was able to deploy
Screenshot 2025-05-18 at 14 11 20

@samaradel samaradel marked this pull request as draft May 22, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants