Group all toggles in one component #4161
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
- Fix manual import in caprover
0oM4R
reviewed
May 21, 2025
Comment on lines
+74
to
+77
| const dedicatedModel = computed({ | ||
| get: () => !!props.dedicated, | ||
| set: val => emit("update:dedicated", val), | ||
| }); |
There was a problem hiding this comment.
👏 its greate to use writable computed here thank you ya Samar
0oM4R
reviewed
May 21, 2025
Comment on lines
+89
to
+103
| function onUpdateRentedByMe(val: boolean | null) { | ||
| rentedByMeModel.value = !!val; | ||
| } | ||
| function onUpdateDedicated(val: boolean | null) { | ||
| dedicatedModel.value = !!val; | ||
| } | ||
| function onUpdateCertified(val: boolean | null) { | ||
| certifiedModel.value = !!val; | ||
| } | ||
| function onUpdateHasGPU(val: boolean | null) { | ||
| hasGPUModel.value = !!val; | ||
| } |
There was a problem hiding this comment.
i think inline change the values in template would be better, Those founciton are not used anywhere else
example :
:model-value="(val)=> gpuModule = val"
There was a problem hiding this comment.
I did, but it caused type-check errors, let me try adding types there
There was a problem hiding this comment.
@0oM4R I tried it, but it caused the same error I mentioned, so I returned to the previous solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Group all toggles in one component
Changes
Group all toggles in one component across all solutions
Related Issues
Tested Scenarios
RentedByMe,Dedicated, andCertifiedif they do their job correctlyDocumentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist