Remove fullvms from micro vm deployment list

[amiraabouhadid]

Description

updates conditionals used in full vm and vm deployments fetching for deployment list

Changes

• added conditional that checks if current project name matches project name fetched from deployment contract
• used refs for chunks received from load vm method, reset chunks to empty at the beginning of every loadDeployments call
• added loadVm option that passes down showAllDeployment value to the method in order to filter accordingly

Related Issues

#4017

Tested Scenarios

• deploy a full VM , go to micro VM , observe no full VM deployment in micro VM deployment list
• toggle show all deployments, no full VM deployment should be shown

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

• Preliminary Checks
  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

• UI Checks
  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

• Code Quality Checks
  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Testing Checklist

• Does it Meet the specified acceptance criteria.
• Test if changes can affect any other functionality.
• Tested with unit, integration, and end-to-end tests.
• Tested the un-happy path and rollback scenarios.
• Documentation updated to meet the latest changes.
• Check automated tests working successfully with the changes.
• Can be covered by automated tests.

General Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstring
• Screenshots/Video attached (needed for UI changes)

[samaradel]

After deploying a full VM, I switched to microVM, then deployed one, and then switched to Show all deployments. The full VM appeared in the micro VM table for a few seconds, then disappeared

[amiraabouhadid]

hello @ramezsaeed please provide test scenarios

[ramezsaeed]

Test scenarios:

• deploy Full Vm with different Images (other than ubuntu) and make sure they are not listed in MicroVM deploymenst.
• deploy FullVm via grid client and terraform and make sure they are not listed in MicroVM deploymenst..
• deploy FullVM with different sizes and add disks and make sure they are not listed in MicroVM deploymenst.

[ramezsaeed]

why I can see all deploymnet in the deployment sectio and I can scroll right to select all solution even the show all deployments toggle is off ?

[amiraabouhadid]

Test scenarios:

• deploy Full Vm with different Images (other than ubuntu) and make sure they are not listed in MicroVM deploymenst.
• deploy FullVm via grid client and terraform and make sure they are not listed in MicroVM deploymenst..
• deploy FullVM with different sizes and add disks and make sure they are not listed in MicroVM deploymenst.

hello @ramezsaeed please specify test expected result with respect to show all deloyments switch in micro vm

[ramezsaeed]

Test scenarios:

• deploy Full Vm with different Images (other than ubuntu) and make sure they are not listed in MicroVM deploymenst.
• deploy FullVm via grid client and terraform and make sure they are not listed in MicroVM deploymenst..
• deploy FullVM with different sizes and add disks and make sure they are not listed in MicroVM deploymenst.

Test scenarios:

• deploy Full Vm with different Images (other than ubuntu) and make sure they are not listed in MicroVM deployments when toggle is Off, and can't list them when toggle is on too.

• deploy FullVM with different sizes and add disks and make sure they are not listed in MicroVM deployments when toggle is Off, and can't list them when toggle is on too.

• deploy FullVm via grid client and terraform and make sure they are not listed in MicroVM deployments;
  when toggle is Off, and can list them when toggle is on.

[0oM4R]

deployed from dashboard and shown while the toggle is on