Fix GPU card validator #4253

samaradel · 2025-06-24T12:58:04Z

Description

Validate the GPU card selector before deployment

Changes

Screencast.from.24-06-25.15.51.26.webm

Related Issues

Deploy Validation Incorrectly Highlights "Load Nodes" Instead of Missing "GPU Cards" Field #4146

Tested Scenarios

Select node with the GPU and deploy without selecting the GPU card

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

Preliminary Checks
- Does it completely address the issue linked?
- What about edge cases?
- Does it meet the specified acceptance criteria?
- Are there any unintended side effects?
- Does the PR adhere to the team's coding conventions, style guides, and best practices?
- Does it integrate well with existing features?
- Does it impact the overall performance of the application?
- Are there any bottlenecks or slowdowns?
- Has it been optimized for efficiency?
- Has it been adequately tested with unit, integration, and end-to-end tests?
- Are there any known defects or issues?
- Is the code well-documented?
- Are changes to documentation reflected in the code?

UI Checks:

UI Checks
- If a UI design is provided/ does it follow it?
- Does every button work?
- Is the data displayed logical? Is it what you expected?
- Does every validation work?
- Does this interface feel intuitive?
- What about slow network? Offline?
- What if the gridproxy/graphql/chain is failing?
- What would a first time user have a hard time navigating here?

Code Quality Checks:

Code Quality Checks
- Code formatted/linted? Are there unused imports? .. etc
- Is there redundant/repeated code?
- Are there conditionals that are always true or always false?
- Can we write this more concisely?
- Can we reuse this code? If yes, where?
- Will the changes be easy to maintain and update in the future?
- Can this code become too complex to understand for other devs?
- Can this code cause future integration problems?

Testing Checklist

Does it Meet the specified acceptance criteria.
Test if changes can affect any other functionality.
Tested with unit, integration, and end-to-end tests.
Tested the un-happy path and rollback scenarios.
Documentation updated to meet the latest changes.
Check automated tests working successfully with the changes.
Can be covered by automated tests.

General Checklist

0oM4R · 2025-06-29T07:53:10Z

Can you please explain the solution?

I think we should fix that on the formValidator, as this is happening on the domain name as well

Screencast.from.2025-06-29.10-51-11.webm

samaradel · 2025-06-29T12:51:43Z

well,

The class gpu-card-selector was added as styling for the GPU selector container, data-validation-target="gpu-cards" that serves as a marker for the validation and scrolling system
By adding ref="gpuSelect", we can directly access the VSelect component instance
Calling bindStatus() without forcing a specific status. Instead, it uses the improved logic inside the bindStatus function
targetElement used as a computed property so it can get the VSelect's DOM Element to use it with $el
registrationId initialized as an id for the component, and isRegistered to track if it's registered with the form
registerService to register if it's not already registered and to update its isRegistered flag
unregisterService same service as the last point, but for unregister
The onMounted is updated to only register if there's a valid node selected
Update the deep watcher with the registerService and unregisterService

P.S. I made the changes in the Select GPU component itself, if it's exists for the domain component too, please open an issue for it

amiraabouhadid · 2025-06-29T18:25:46Z

packages/playground/src/components/node_selector/TfSelectGpu.vue

+      let s = status;
+
+      if (!s) {
+        if (props.validNode && props.node && props.modelValue.length === 0) {
+          s = ValidatorStatus.Invalid;
+        } else if (props.validNode && props.node && props.modelValue.length > 0) {
+          s = ValidatorStatus.Valid;
+        } else {
+          s = ValidatorStatus.Init;
+        }
+      }
+


Suggested change

let s = status;

if (!s) {

if (props.validNode && props.node && props.modelValue.length === 0) {

s = ValidatorStatus.Invalid;

} else if (props.validNode && props.node && props.modelValue.length > 0) {

s = ValidatorStatus.Valid;

} else {

s = ValidatorStatus.Init;

}

}

let s = status;

if (!s) {

if (props.validNode && props.node) {

s = props.modelValue.length === 0

? ValidatorStatus.Invalid

: ValidatorStatus.Valid;

} else {

s = ValidatorStatus.Init;

}

}

amiraabouhadid · 2025-06-29T18:31:25Z

correctly highlights unselected gpu cards

amiraabouhadid · 2025-06-29T18:32:31Z

correctly highlights unselected gpu cards

amiraabouhadid · 2025-07-01T13:36:19Z

waiting on mainnet tokens to continue testing. also encountered this #4261 (comment)

0oM4R · 2025-07-13T10:45:47Z

P.S. I made the changes in the Select GPU component itself, if it's exists for the domain component too, please open an issue for it

@samaradel

What I'm talking about is checking if the fix can be done on the parent component, so that will solve both issues.

amiraabouhadid

works

please address @0oM4R comment before merging

0oM4R · 2025-07-13T13:03:39Z

P.S. I made the changes in the Select GPU component itself, if it's exists for the domain component too, please open an issue for it

@samaradel

What I'm talking about is checking if the fix can be done on the parent component, so that will solve both issues.

This is not a blocking request. If you are sure that the fix is only related to the GPU component, go ahead and merge, and we can handle the domain name in another issue

- Add data dttribute targeting - Add custom CSS selector - Add same error highlighting across all components

samaradel · 2025-07-14T16:44:17Z

@0oM4R @amiraabouhadid, it's all changed now as per #4253 (comment) please review

more changes added

amiraabouhadid · 2025-07-16T17:22:37Z

please resolve conflicts

amiraabouhadid

no available gpu nodes on devnet to test with, waiting on funds on mainnet to test

amiraabouhadid

works

Fix GPU card validator

194ef48

samaradel requested review from AhmedHanafy725, zaelgohary, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar and 0oM4R as code owners June 24, 2025 12:58

samaradel marked this pull request as draft June 29, 2025 10:59

samaradel marked this pull request as ready for review June 29, 2025 12:52

samaradel mentioned this pull request Jun 29, 2025

Deploy Validation Incorrectly Highlights "Load Nodes" Instead of Missing "GPU Cards" Field #4146

Closed

amiraabouhadid reviewed Jun 29, 2025

View reviewed changes

samaradel marked this pull request as draft June 30, 2025 09:48

Refactor and reduce checking node validation

3d80ffe

samaradel marked this pull request as ready for review June 30, 2025 11:17

samaradel requested a review from amiraabouhadid July 1, 2025 08:17

amiraabouhadid previously approved these changes Jul 13, 2025

View reviewed changes

samaradel marked this pull request as draft July 14, 2025 14:57

samaradel added 3 commits July 14, 2025 19:21

- Create form validation helpers file for highlighting and scrolling

45d4ef7

- Add data dttribute targeting - Add custom CSS selector - Add same error highlighting across all components

Merge branch 'development' into dev_GPU_card

5ec83b7

Remove unused value to fix linting

b530047

samaradel marked this pull request as ready for review July 14, 2025 16:31

samaradel requested a review from amiraabouhadid July 14, 2025 16:43

Merge branch 'development' into dev_GPU_card

e0c86a1

amiraabouhadid reviewed Jul 20, 2025

View reviewed changes

amiraabouhadid reviewed Jul 21, 2025

View reviewed changes

amiraabouhadid approved these changes Jul 21, 2025

View reviewed changes

samaradel merged commit 0d6a22a into development Jul 21, 2025
12 checks passed

samaradel deleted the dev_GPU_card branch July 21, 2025 18:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix GPU card validator #4253

Fix GPU card validator #4253

samaradel commented Jun 24, 2025 •

edited

Loading

Uh oh!

0oM4R commented Jun 29, 2025 •

edited

Loading

Uh oh!

samaradel commented Jun 29, 2025 •

edited

Loading

Uh oh!

amiraabouhadid Jun 29, 2025

Uh oh!

amiraabouhadid commented Jun 29, 2025

Uh oh!

amiraabouhadid commented Jun 29, 2025

Uh oh!

amiraabouhadid commented Jul 1, 2025

Uh oh!

0oM4R commented Jul 13, 2025

Uh oh!

amiraabouhadid left a comment

Uh oh!

0oM4R commented Jul 13, 2025

Uh oh!

samaradel commented Jul 14, 2025

Uh oh!

amiraabouhadid commented Jul 16, 2025

Uh oh!

amiraabouhadid left a comment

Uh oh!

amiraabouhadid left a comment

Uh oh!

Uh oh!

Uh oh!

Fix GPU card validator #4253

Fix GPU card validator #4253

Conversation

samaradel commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Related Issues

Tested Scenarios

Documentation PR

To consider

Preliminary Checks:

UI Checks:

Code Quality Checks:

Testing Checklist

General Checklist

Uh oh!

0oM4R commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samaradel commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amiraabouhadid Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

amiraabouhadid commented Jun 29, 2025

Uh oh!

amiraabouhadid commented Jun 29, 2025

Uh oh!

amiraabouhadid commented Jul 1, 2025

Uh oh!

0oM4R commented Jul 13, 2025

Uh oh!

amiraabouhadid left a comment

Choose a reason for hiding this comment

Uh oh!

0oM4R commented Jul 13, 2025

Uh oh!

samaradel commented Jul 14, 2025

Uh oh!

amiraabouhadid commented Jul 16, 2025

Uh oh!

amiraabouhadid left a comment

Choose a reason for hiding this comment

Uh oh!

amiraabouhadid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

samaradel commented Jun 24, 2025 •

edited

Loading

0oM4R commented Jun 29, 2025 •

edited

Loading

samaradel commented Jun 29, 2025 •

edited

Loading