-
Notifications
You must be signed in to change notification settings - Fork 8
Enhance SSH dialog user experience #4260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0oM4R
wants to merge
16
commits into
development
Choose a base branch
from
development_ssh_UX
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e3f4a2c
feat[SSH Key dialog]:
0oM4R 3790309
Chore: make handlepostlogin after setting the profile
0oM4R fa2c46b
handle multiple sshkeys in the sshmanager
0oM4R 6d3de06
feat: add validator to allow alphanumiric with inner space
0oM4R 2bac846
Feat: support update sshkes names
0oM4R c4f2620
fix: update SSH key management logic to use oldKeys for default name …
0oM4R 3bc8b86
fix: update loading state and message for SSH key recovery
0oM4R f4224a6
fix: update isAlphanumericWithSpace validator return type and logic
0oM4R bc9c578
feat: enhance SSH key name validation and trim trailing spaces
0oM4R 6c813b7
feat: add name validation for SSH keys with alphanumeric and length c…
0oM4R 4bac672
Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-ts …
0oM4R aafda9b
feat: add success toast notification when SSH keys are recovered
0oM4R 856b62d
eslint: fix workflow
0oM4R a367275
test: allow single trailing space in alphanumeric validator
0oM4R dc045c0
resote doc file
0oM4R a100173
Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-ts …
0oM4R File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keys will be renamed, this is to make the user aware of what happened to the keys