Fix subdomain name duplicates

[samaradel]

Description

Fix subdomain name duplicates when the dialog fires

Changes

Screencast.from.30-06-25.15.39.51.webm

Related Issues

• 🐞 [Bug]: Update Subdomain Suggested Name #3901

Tested Scenarios

• Check the last deployed domain and check the subdomain name in the Add New Domain tab
• Deploy the new domain and then go back to the Add New Domain tab again and check subdomain name
• Close and open the dialog and check the subdomain name

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

• Preliminary Checks
  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

• UI Checks
  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

• Code Quality Checks
  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Testing Checklist

• Does it Meet the specified acceptance criteria.
• Test if changes can affect any other functionality.
• Tested with unit, integration, and end-to-end tests.
• Tested the un-happy path and rollback scenarios.
• Documentation updated to meet the latest changes.
• Check automated tests working successfully with the changes.
• Can be covered by automated tests.

General Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstring
• Screenshots/Video attached (needed for UI changes)

[amiraabouhadid]

Screen.Recording.2025-07-01.at.15.45.42.mov

still gives name exists error

[amiraabouhadid]

neat fix but given we can choose any two alphabetical characters while allowing repition, then we've got 26 x 26 = 676 options only. Let's hope user doesn't need more than that haha

[amiraabouhadid]

can we please do the same but without using a watcher for efficiency?

[amiraabouhadid]

can't seem to be able to add a domain to test this

[samaradel]

Ok, but it's about renaming the subdomains. As it's not duplicated anymore, the error is not related