Skip to content

Fix adding public IP validations #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Jul 1, 2025

Description

Improved the form validation in the add_ip.vue component

Changes

  • Removed immediate validation triggers
  • Validation only on submit
  • Improved validation order & logic

Related Issues

Tested Scenarios

  • Fields should not show errors while the user is typing
  • Errors appear only when the "Add" button is clicked
  • After successful submission, the form should clear and reset the validation state

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

- Validation only on submit
- Improved validation order & logic
@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Jul 1, 2025

it still shows that this Ip is invalid even though it should say different network as mentioned in the attached issue
Screenshot 2025-07-01 at 15 39 22

@samaradel samaradel marked this pull request as draft July 2, 2025 10:12
@samaradel samaradel marked this pull request as ready for review July 2, 2025 10:28
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add btn should be disabled while form is invalid
Screenshot 2025-07-02 at 20 52 05
Show IPs range as well; it should probably be disabled when the form is invalid.

@samaradel samaradel marked this pull request as draft July 7, 2025 10:24
@samaradel samaradel marked this pull request as ready for review July 7, 2025 10:33
@samaradel samaradel requested a review from amiraabouhadid July 7, 2025 10:33
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please disable the show Ip range btn as well as it freezes if u click on it when there is an invalid ip range
Screenshot 2025-07-13 at 14 36 03

@samaradel samaradel marked this pull request as draft July 15, 2025 08:35
@samaradel samaradel marked this pull request as ready for review July 15, 2025 09:28
@samaradel samaradel requested a review from amiraabouhadid July 15, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants