Only log ygg logs in console

[samaradel]

Description

Only log ygg logs in the console, not in the logs dialog, while deploying

Changes

Log the ygg logs in the console only

Related Issues

• Deployment Logs Show Ygg Network Interface While Deployments Only Have Mycelium IP #4230

Tested Scenarios

• Deploy a worker for k8s, for example and check ygg logs info in the dialog and in the console

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

• Preliminary Checks
  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

• UI Checks
  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

• Code Quality Checks
  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Testing Checklist

• Does it Meet the specified acceptance criteria.
• Test if changes can affect any other functionality.
• Tested with unit, integration, and end-to-end tests.
• Tested the un-happy path and rollback scenarios.
• Documentation updated to meet the latest changes.
• Check automated tests working successfully with the changes.
• Can be covered by automated tests.

General Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstring
• Screenshots/Video attached (needed for UI changes)

[amiraabouhadid]

still shows up in logs somehow

shows up in console correctly

please check if logs is called somewhere else with the network interfaces

[samaradel]

The change I made is to prevent emits and use the console instead, so it will not be anywhere else

[0oM4R]

Works fine, please consider handling other logs that should not appear
Or you can open an issue for it

[samaradel]

Works fine, please consider handling other logs that should not appear Or you can open an issue for it

@AhmedHanafy725, should be handled too

[amiraabouhadid]

The change I made is to prevent emits and use the console instead, so it will not be anywhere else

I understand but why is ygg still showing in the console for deployments that dont have it is what I am asking
as I understand from the linked issue, ygg should not show even in the console for deployments that dont have ygg network interface ...
confusion resolved in scrum, thanks samar!

changes added