-
Notifications
You must be signed in to change notification settings - Fork 8
add gateway url in successfully deployed msg #4282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -411,7 +413,11 @@ export default { | |||
|
|||
await deployGatewayName(grid, selectionDetails.value!.domain, gwConfig); | |||
suggestName(); | |||
layout.value.setStatus("success", "Successfully deployed gateway."); | |||
// get gateway url | |||
await loadGateways(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I have a suggestion: what about constructing the URL from the data we already have?
@@ -411,7 +413,11 @@ export default { | |||
|
|||
await deployGatewayName(grid, selectionDetails.value!.domain, gwConfig); | |||
suggestName(); | |||
layout.value.setStatus("success", "Successfully deployed gateway."); | |||
// get gateway url | |||
await loadGateways(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await loadGateways(); | |
const gatewayUrl = selectionDetails.value!.domain!.useFQDN | |
? `https://${selectionDetails.value!.domain!.customDomain}` | |
: `https://${gwConfig.subdomain}.${selectionDetails.value!.domain!.selectedDomain!.publicConfig.domain}`; |
so there's no need for an extra api call or find method, anyway it's up to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion, thanks
Description
added gateway url in successfully deployed msg
Changes
add gateway and its url fetching after deploying gateway
include gatway url in successful deployment msg
Related Issues
#4222
Tested Scenarios
Documentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist