Skip to content

Refactor twin_id shouldn't be requested from the user in creation of farm or node #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Refactor twin_id shouldn't be requested from the user in creation of farm or node #11

wants to merge 5 commits into from
+87 −56

Conversation

SalmaElsoly
Copy link
Contributor

Changes:

  • store twin id on creating registrar client by querying it
  • store twin id on creating account
  • use stored twin id in creating and updating of farm or node

Related issues:

#10

@SalmaElsoly SalmaElsoly requested a review from zaelgohary March 17, 2025 07:20
AlaaElattar
AlaaElattar reviewed May 20, 2025
View reviewed changes
@SalmaElsoly SalmaElsoly requested a review from AlaaElattar May 21, 2025 08:47
AlaaElattar
AlaaElattar reviewed May 21, 2025
View reviewed changes
@SalmaElsoly SalmaElsoly requested a review from AlaaElattar May 21, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SalmaElsoly @AlaaElattar