fix farm tests

Author: Eslam-Nawara

node-registrar/client/farm.go

@@ -156,7 +156,7 @@ func (c *RegistrarClient) createFarm(farmName, stellarAddr string, dedicated boo
 }
 
 func (c *RegistrarClient) updateFarm(farmID uint64, opts []UpdateFarmOpts) (err error) {
-	if c.ensureTwinID(); err != nil {
+	if err = c.ensureTwinID(); err != nil {
 		return errors.Wrap(err, "failed to ensure twin id")
 	}
 
@@ -308,10 +308,7 @@ func parseListFarmOpts(opts []ListFarmOpts) map[string]any {
 }
 
 func parseUpdateFarmOpts(opts []UpdateFarmOpts) map[string]any {
-	cfg := farmCfg{
-		farmName:  "",
-		dedicated: false,
-	}
+	cfg := farmCfg{}
 
 	for _, opt := range opts {
 		opt(&cfg)
@@ -326,6 +323,7 @@ func parseUpdateFarmOpts(opts []UpdateFarmOpts) map[string]any {
 	if cfg.dedicated {
 		data["dedicated"] = true
 	}
+
 	if len(cfg.stellarAddress) != 0 {
 		data["stellar_address"] = cfg.stellarAddress
 	}

node-registrar/client/farm_test.go

@@ -35,15 +35,16 @@ func TestCreateFarm(t *testing.T) {
 	c, err := NewRegistrarClient(baseURL, testMnemonic)
 	require.NoError(err)
 
+	stellarAddr := "GBB3H4F7N3R26I6XU2V2P5WYJZQ5N7E4FQH6E5D2X3OGJ2KLTGZXQW34"
 	t.Run("test create farm with status conflict", func(t *testing.T) {
 		request = createFarmStatusConflict
-		_, err = c.CreateFarm(farm.FarmName, farm.Dedicated)
+		_, err = c.CreateFarm(farm.FarmName, stellarAddr, farm.Dedicated)
 		require.Error(err)
 	})
 
 	t.Run("test create farm with status ok", func(t *testing.T) {
 		request = createFarmStatusCreated
-		result, err := c.CreateFarm(farm.FarmName, farm.Dedicated)
+		result, err := c.CreateFarm(farm.FarmName, stellarAddr, farm.Dedicated)
 		require.NoError(err)
 		require.Equal(farm.FarmID, result)
 	})