Add registrar cli tool#14
Open
Eslam-Nawara wants to merge 17 commits into
Open
Conversation
Eslam-Nawara
requested review from
AbdelrahmanElawady,
Omarabdul3ziz,
ashraffouda,
mariobassem,
rawdaGastan,
sameh-farouk and
xmonader
as code owners
xmonader
reviewed
Feb 27, 2025
xmonader
reviewed
Feb 27, 2025
Eslam-Nawara
force-pushed
the
development-add-node-registrar-client
branch
from
9d8b469 to
7908c98
Compare
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
from
0e28331 to
9331ff4
Compare
Eslam-Nawara
force-pushed
the
development-add-node-registrar-client
branch
from
513a105 to
3eb0fb7
Compare
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
2 times, most recently
from
1b46b0b to
bb9c8a8
Compare
Base automatically changed from
development-add-node-registrar-client
to
development
March 20, 2025 14:46
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
from
08ea35b to
deaa8c8
Compare
Nabil-Salah
reviewed
Mar 23, 2025
|
|
||
| func init() { | ||
| accountCmd.AddCommand(accountCreateCmd) | ||
| accountCreateCmd.Flags().StringP("mnemonic", "m", "", "account mnemonic") |
Contributor
There was a problem hiding this comment.
I see adding this flag multiple times
as a suggestion, I'm thinking of a helper function like this
func addMnemonicFlag(cmd *cobra.Command) {
cmd.Flags().StringP("mnemonic", "m", "", "account mnemonic")
}
so making future changes easier and removing repetition
Contributor
|
also you can add binaries created to |
Collaborator
Author
already files in bin/ are in the gitignore |
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
from
57d63e3 to
de1d2e3
Compare
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
from
de1d2e3 to
9e42402
Compare
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
from
f43e7ff to
8aafe91
Compare
Eslam-Nawara
force-pushed
the
add-registrar-cli-tool
branch
from
f2d6904 to
cc17217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace new-account and new-farm tools with one tool, registrar-cli allowing user to use one tool to interact and manage version, farms, accounts and nodes
Changes
Related Issues
Checklist