Add mnemonics to registrar client #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
rawdaGastan
requested changes
Mar 5, 2025
|
|
||
| cli, err := client.NewRegistrarClient(registrarURL, s) | ||
| cli, err := client.NewRegistrarClient(registrarURL, mnemonic) |
There was a problem hiding this comment.
why passing mnemonic to the client?
There was a problem hiding this comment.
it's optional, user can initialize the client with or without the mnemonic, it the user already has an account, they can pass it to the client as in the tfpluginclient, if not they can just not pass mnemonic and has a client with no account.
|
|
||
| func parseKeysFromMnemonicOrSeed(mnemonicOrSeed string) (keypair subkey.KeyPair, err error) { | ||
| // otherwise drive key pair from seed | ||
| keypair, err = subkey.DeriveKeyPair(subkeyEd25519.Scheme{}, mnemonicOrSeed) |
There was a problem hiding this comment.
won't sr25519 be supported?
There was a problem hiding this comment.
it's supported in the server, if needed we can support them too in the client, we need to pick a default tho
ashraffouda
merged commit 9d8b469
into
development-add-node-registrar-client
4 checks passed
Eslam-Nawara
added a commit
that referenced
this pull request
Mar 9, 2025
* support mnemonics in registrar client * fix drive keys from seed * update registrar client readme file * remove extra print lines * remove extra comments * lower case error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support using mnemonics to node registrar client
Changes
List of changes this PR includes
Related Issues
Checklist