Skip to content

update node ips type to []string #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025

Conversation

Eslam-Nawara
Copy link
Collaborator

Description

ips in node interfaces are created as strings, we need to update them to []string to match zos3 nodes

Changes

  • update ips to be []string
  • add migration code to update old nodes if not updated.

Related Issues

List of related issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

@Eslam-Nawara Eslam-Nawara merged commit 1169745 into development Apr 6, 2025
18 checks passed
@Eslam-Nawara Eslam-Nawara deleted the development-update-node-ips-type branch April 6, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants