refactor node registrar #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
ashraffouda
approved these changes
Mar 20, 2025
Eslam-Nawara
force-pushed
the
development-refactor-registrar
branch
from
aaf6d30 to
244a4fb
Compare
xmonader
reviewed
Mar 25, 2025
| @@ -21,39 +21,39 @@ func (s *Server) SetupRoutes() { | |||
| })) | |||
|
|
|||
| s.router.GET("/swagger/*any", ginSwagger.WrapHandler(swaggerFiles.Handler)) | |||
| v1 := s.router.Group("v1") | |||
There was a problem hiding this comment.
need to also support /v1 that we had because this will break the current nodes no?
xmonader
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor node registrar
Related Issues
Checklist