Skip to content

Development add fallback for node interface #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Eslam-Nawara
Copy link
Collaborator

@Eslam-Nawara Eslam-Nawara commented May 4, 2025

Changes

  • skip updating node if it has no interface
  • handle if node used old interface and/or uptime format
  • add validation to node Interface length

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

@Eslam-Nawara Eslam-Nawara marked this pull request as draft May 5, 2025 09:17
@xmonader xmonader changed the title Development add fullback for node interface Development add fallback for node interface May 5, 2025
@Eslam-Nawara Eslam-Nawara force-pushed the development-add-fullback-for-node-interface branch from 1567ed2 to 4db756a Compare May 5, 2025 16:32
@Eslam-Nawara Eslam-Nawara marked this pull request as ready for review May 6, 2025 10:28
@Eslam-Nawara Eslam-Nawara force-pushed the development-add-fullback-for-node-interface branch from 839370e to f90938f Compare May 6, 2025 10:34
@Eslam-Nawara Eslam-Nawara force-pushed the development-add-fullback-for-node-interface branch from f90938f to 9f9874f Compare May 6, 2025 10:39
@Eslam-Nawara Eslam-Nawara merged commit e159175 into development May 6, 2025
4 checks passed
@Eslam-Nawara Eslam-Nawara deleted the development-add-fullback-for-node-interface branch May 6, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants