update registrar to expect address instead of expecting domain #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
ashraffouda
approved these changes
Jun 2, 2025
Eslam-Nawara
force-pushed
the
development-fix-domain-as-address
branch
4 times, most recently
from
760bd52 to
6be8660
Compare
xmonader
requested changes
Jun 10, 2025
xmonader
reviewed
Jun 12, 2025
node-registrar/cmds/main.go
Outdated
|
|
||
| // Check common binding addresses | ||
| switch host { | ||
| case "localhost", "0.0.0.0", "127.0.0.1": |
There was a problem hiding this comment.
how about the ipv6 loop back?
|
Looks good, please check if there should be any special handling for ipv6 loopback or not and then merge |
updated, should I merge? |
Eslam-Nawara
force-pushed
the
development-fix-domain-as-address
branch
from
9a54053 to
17402f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update registrar to expect address instead of expecting domain
Changes
update registrar to expect address instead of expecting domain
Related Issues
Checklist