Skip to content

Allow activating imported wallets #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AhmedHanafy725 opened this issue Mar 27, 2025 · 6 comments
Open

Allow activating imported wallets #978

AhmedHanafy725 opened this issue Mar 27, 2025 · 6 comments
Assignees
@AlaaElattar
Labels
type_feature
Milestone
4.3.x

Comments

@AhmedHanafy725
Copy link
Contributor

Allow the wallet activation on stellar by paying fees from any other wallet.
@ramezsaeed
Copy link

Acceptance test:

  • User should be able to pay activation fees from his own old wallet to activate his new wallet.
  • Threefold activate only the first wallet created (Daily wallet)
  • we get TFT from the user and send XLM to the activation service (we need to check the rate)

@ramezsaeed ramezsaeed added this to 3.17 Apr 15, 2025
@ramezsaeed ramezsaeed added this to the 4.3.x milestone Apr 15, 2025
@AlaaElattar AlaaElattar self-assigned this May 1, 2025
@AlaaElattar AlaaElattar moved this to In Progress in 3.17 May 1, 2025
@AlaaElattar
Copy link
Contributor

Work In Progress:

  • Fixed the activation flow.
  • Found bug related to context mounting when trying to activated after adding wallet directly, trying to solve it.

@AlaaElattar AlaaElattar moved this from In Progress to Accepted in 3.17 May 5, 2025
@AlaaElattar AlaaElattar moved this from Accepted to In Progress in 3.17 May 5, 2025
@AlaaElattar AlaaElattar mentioned this issue May 5, 2025
Merged
@AhmedHanafy725 AhmedHanafy725 removed this from 3.17 May 6, 2025
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 4.3.x, 4.4.x May 6, 2025
@AlaaElattar
Copy link
Contributor

Work Completed:

  • Implemented feature so user can activate stellar wallet throughout another wallet.

@AhmedHanafy725 AhmedHanafy725 moved this to Pending Review in 3.17 May 6, 2025
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 4.4.x, 4.3.x May 6, 2025
@AlaaElattar AlaaElattar moved this from Pending Review to In Progress in 3.17 May 6, 2025
@AlaaElattar
Copy link
Contributor

Work Completed:

  • Applied pr comments

@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.17 May 7, 2025
@AlaaElattar AlaaElattar moved this from Pending Review to In Progress in 3.17 May 11, 2025
@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.17 May 11, 2025
@AlaaElattar
Copy link
Contributor

Work completed:

  • Handled when account activated but has no trusline.

@AlaaElattar AlaaElattar moved this from Pending Review to In Progress in 3.17 May 11, 2025
@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.17 May 11, 2025
@AlaaElattar
Copy link
Contributor

Work Completed:

  • Added tft && activation check when loading balance.

@AlaaElattar AlaaElattar moved this from Pending Review to Pending Deployment in 3.17 May 11, 2025
@ramezsaeed ramezsaeed moved this from Pending Deployment to In Verification in 3.17 May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlaaElattar AlaaElattar

Labels
type_feature
Projects
3.17
Status: In Verification
Milestone
4.3.x
Development

No branches or pull requests
3 participants
@ramezsaeed @AhmedHanafy725 @AlaaElattar