Skip to content

Connectivity check #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Connectivity check #1026

wants to merge 2 commits into from

Conversation

AlaaElattar
Copy link
Contributor

Changes

  • Handled connectivity check and timeout for news, signing and wallet screens.

Related Issues

#1025

Tested Scenarios

  • Tested all screens with no and bad internet connection.

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News screen shows errors in a toast and persistent in the screen itself. This doesn't happen anywhere else. Can we remove the persistent one for consistency?

@zaelgohary
Copy link
Contributor

zaelgohary commented May 21, 2025

It might not be intuitive for the user to click the reload button, as it doesn't stand out on the page, while the dropdown already contains the wallets' names. What if we checked for connectivity in the sign screen instead, and show the try again button as in other screens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants