Skip to content

Background service to check if node goes offline #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Apr 30, 2025
Merged

Background service to check if node goes offline #994

merged 48 commits into from
Apr 30, 2025

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Apr 9, 2025 •
edited
Loading

Changes

  • Added flutter_local_notifications package for handling notifications.
  • Added background_fetch for background checking on nodes.
  • Categorized nodes into groups based on how long they've been offline:
    • Recent: 0–1 hour
    • Hour: 1–4 hours
    • Day: 4–24 hours
    • Days: 1–7 days
    • Beyond 7 days: Ignored
  • Handled tapping on notification to open dialog contains same data.

Related Issues

Tested Scenarios

  • Tested with offlline nodes.

@AlaaElattar AlaaElattar marked this pull request as draft April 9, 2025 11:54
@AlaaElattar AlaaElattar changed the title WIP: adding notifications pgk Background service to check if node goes offline Apr 13, 2025
@AlaaElattar AlaaElattar marked this pull request as ready for review April 13, 2025 09:45
zaelgohary
zaelgohary reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix build workflow?

@AlaaElattar
Copy link
Contributor Author

AlaaElattar commented Apr 13, 2025 •
edited
Loading

Can you fix build workflow?

The issue in the build apk not the format workflow.
I have nothing related to the apk.

@AlaaElattar AlaaElattar requested a review from zaelgohary April 13, 2025 10:06
@zaelgohary
Copy link
Contributor

zaelgohary commented Apr 13, 2025 •
edited
Loading

Can you fix build workflow?

The issue in the build apk not the format workflow. I have nothing related to the apk.

The workflow fails on this branch only. It works fine on other branches. Maybe it's sth related to the new package?

@AlaaElattar AlaaElattar marked this pull request as draft April 13, 2025 11:48
@AlaaElattar
WIP: adding permissions for android
fd5ee16
@AlaaElattar
WIP: downgrade background_fetch
e7939be
@AlaaElattar
WIP: downgrade background_fetch
b8d1983
@AlaaElattar
clear cached background_fetch
d8ec42a
@AlaaElattar
specify ndk version
09fcf79
@AlaaElattar
undo nkd version setup
039d0a7
@AlaaElattar
WIP: add debug logs
79255c0
@AlaaElattar
WIP: debug background_fetch version
7536668
@AlaaElattar
update pubspec.lock
c63e68d
@AlaaElattar
update build.gradle
62ac54d
@AlaaElattar
WIP: remove gradle cache
e3eeef0
@AlaaElattar
fix command
e79387a
@AlaaElattar
WIP: Update build.gradle
d3aa5a1
@AlaaElattar
WIP: fix space
940a189
@AlaaElattar
undo latest commit
2f74467
@AlaaElattar
add maven url in build.gradle
c5d36b4
@AlaaElattar @AhmedHanafy725
Add close button for confirmation dialog (#976)
58933f1 
* add close button for confirmation dialog

* add cancel btn in bridge also
@AlaaElattar @AhmedHanafy725
Handle non-loading for delete wallet (#973)
a719351 
* add timeout 1 min for deleting wallet

* update error messages
@AlaaElattar @AhmedHanafy725
Prevent PIN Entry Attempts During 30 Second Lockout Period (#989)
bd2625d 
* keep user locked after the many attempts

* update pin screen to include live counter
AhmedHanafy725
AhmedHanafy725 requested changes Apr 23, 2025
View reviewed changes
@AlaaElattar AlaaElattar marked this pull request as draft April 24, 2025 07:46
@AlaaElattar AlaaElattar marked this pull request as ready for review April 24, 2025 11:19
AhmedHanafy725
AhmedHanafy725 reviewed Apr 28, 2025
View reviewed changes
@AlaaElattar AlaaElattar marked this pull request as draft April 28, 2025 12:46
zaelgohary and others added 8 commits April 28, 2025 15:53
@zaelgohary @AlaaElattar
Hide show phrase (#995)
3aeeeeb
@AlaaElattar
Handle duplicated contacts in favorite List (#983)
48b9cd1 
* handle duplicated contacts

* undo latest solution

* fix adding duplicated wallet in fav list

* Fixed the duplicated contacts issue

* update condition when editing address
@zaelgohary @AlaaElattar
Fix auth timeout routing (#1000)
7b09e6a 
* Creating app lifecycle observer and use it in main.dart w navigator key, Replace Navigator routes w  navigator key

* Remove unused code

* Revert navigator key changes from screens

* Revert main screen changes
@AlaaElattar
fix ios issue and show notification with offline nodes
b877ea9
@AlaaElattar
update pubspec.lock
ffead77
@AlaaElattar
Merge branch 'development' into development_check_nodes
e0b7121
@AlaaElattar
fix workflow
4a4be60
@AlaaElattar
fix equation && workflow
a0016f7
@AlaaElattar AlaaElattar marked this pull request as ready for review April 28, 2025 13:51
@AlaaElattar AlaaElattar marked this pull request as draft April 30, 2025 06:52
@AlaaElattar AlaaElattar marked this pull request as ready for review April 30, 2025 08:13
AhmedHanafy725
AhmedHanafy725 reviewed Apr 30, 2025
View reviewed changes
@AlaaElattar AlaaElattar merged commit 91299b1 into development Apr 30, 2025
2 checks passed
@AlaaElattar AlaaElattar deleted the development_check_nodes branch April 30, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlaaElattar @zaelgohary @AhmedHanafy725