feat: Complete Allowlist implementation for beta staker consolidation #3833
+1,101
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
force-pushed
the
feat/allowlist
branch
from
412a8e6 to
dc885cb
Compare
- Add Allowlist contract to replace TokenStaking per TIP-092/TIP-100 - Implement weight-based operator management without token staking - Add deployment and initialization scripts - Include consolidation script for operator reduction (20→4 operators) - Includes NUCO operators (1 kept, 1 consolidated) - Add comprehensive test coverage - Maintain compatibility with existing WalletRegistry interface
piotr-roslaniec
force-pushed
the
feat/allowlist
branch
from
dc885cb to
8281c38
Compare
piotr-roslaniec
requested review from
lrsaturnino and
pdyraga
and removed request for
lrsaturnino and
pdyraga
kathleenmotley49-maker
approved these changes
Sep 1, 2025
kathleenmotley49-maker
approved these changes
Sep 1, 2025
piotr-roslaniec
dismissed stale reviews from kathleenmotley49-maker and kathleenmotley49-maker
Dismissing fraudulent review from compromised account (Incident: THRESH-SEC-2025-001)
- Add two-step process enforcement for weight decrease (Issue #1) - Introduce decreasePending flag to track valid decrease requests - Prevent bypassing the intended authorization flow - Add zero address validation (Issue #3) - Validate walletRegistry in initialize() - Validate stakingProvider in addStakingProvider() - Add zero weight validation (Issue #5) - Prevent adding staking providers with zero weight - Avoid potential duplicate additions - Add comprehensive test coverage for all security fixes Note: Issue #8 (seize function access) intentionally not restricted as public reporting of malicious behavior is desired functionality
piotr-roslaniec
force-pushed
the
feat/allowlist
branch
from
898958e to
4ad1404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PR #3826 by implementing missing components for Allowlist contract: