Fix windows build for pytorch 2.9 #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes thu-ml#242. I'm no expert on this and used Gemini/Chatgpt to figure this out -- basically, the latest PyTorch introduced some more aggressive checks on build flags, which ended up discovering the pre-existing issue in sage attention's `setup.py`. This patch fixes that.
|
Would be great if someone with Windows could test this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242.
I'm no expert on this and used Gemini/Chatgpt to figure this out -- basically, the latest PyTorch introduced some more aggressive checks on build flags, which ended up discovering the pre-existing issue in sage attention's
setup.py. This patch fixes that.