LoongArch: Fixed a MP wake up bug and enabled IPI vectors. #10984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
AydenMeng,
jiaxinwu,
kraxel,
LiuZhiguang001,
lzeng14,
MarsDoge,
niruiyu,
rahul1-kumar,
td36 and
zhangbaoqi-ls
MarsDoge
reviewed
Apr 21, 2025
UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/LoongArch64/ArchExceptionHandler.c
Show resolved
Hide resolved
MarsDoge
approved these changes
Apr 21, 2025
kilaterlee
force-pushed
the
Submit0421
branch
3 times, most recently
from
feb890c to
1e1a53b
Compare
AydenMeng
reviewed
Apr 27, 2025
UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/LoongArch64/ArchExceptionHandler.c
Outdated
Show resolved
Hide resolved
AydenMeng
reviewed
Apr 27, 2025
UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/LoongArch64/ArchExceptionHandler.c
Show resolved
Hide resolved
AydenMeng
reviewed
Apr 27, 2025
AydenMeng
approved these changes
Apr 27, 2025
|
@niruiyu Hi Ray, cloud you please help to check this patch set and approve it? |
kilaterlee
force-pushed
the
Submit0421
branch
2 times, most recently
from
b549855 to
8518ff1
Compare
If the AP wakes up out of order for the 1st time, and the data in the HOB is also out of order, then there will be a issue: if the big number core wakes up before the small number core, the big number core will modify the APIC number in the CpuMpData, which will cause the small number core can not be wake up. Using the APIC number from the HOB to wake up the APs can fix it. Signed-off-by: Chao Li <lichao@loongson.cn> Cc: Ray Ni <ray.ni@intel.com> Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Dun Tan <dun.tan@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Dongyan Qian <qiandongyan@loongson.cn> Cc: Xiangdong Meng <mengxiangdong@loongson.cn>
Since the LoongArch AP boot SPEC is published, it can identify which IPI by vector. Added IPI vector logic and enabled them. Signed-off-by: Chao Li <lichao@loongson.cn> Cc: Ray Ni <ray.ni@intel.com> Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Dun Tan <dun.tan@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Dongyan Qian <qiandongyan@loongson.cn> Cc: Xiangdong Meng <mengxiangdong@loongson.cn>
jiaxinwu
approved these changes
May 8, 2025
lgao4
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How This Was Tested
Using out-of-order wake-up APs, they can start correctly.
Integration Instructions
<N/A>