Skip to content

Conversation

@GeorgeLiao012
Copy link
Contributor

@GeorgeLiao012 GeorgeLiao012 commented Oct 9, 2025

Description

  1. Fixed memory corruption issue in the InstallAcpiTableFromAcpiSiliconHob().
  2. Added "PCD switch to avoid using ACPI reclaim memory" support in the InstallAcpiTableFromAcpiSiliconHob().
  3. Added "PublishTables()" and "SdtNotifyAcpiList()" for completing AddTableToList behavior in the InstallAcpiTableFromAcpiSiliconHob().
  4. Improving InitializeAcpiTableDxe() behavior.
  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

SUT booting to the operation system with ACPI tables that installed in the ACPI Hob

Integration Instructions

None

@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

@GeorgeLiao012
Copy link
Contributor Author

@ankit13s @mdkinney Could you help to review this PR? Thanks.

@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_memory_corruption_issue_with_InstallAcpiTableFromAcpiSiliconHob branch from 26dfb9a to 7efe90d Compare October 13, 2025 04:05
@GeorgeLiao012
Copy link
Contributor Author

@dandanbi @LiuZhiguang001 Could you help to review this PR? Thanks.

@GeorgeLiao012
Copy link
Contributor Author

@lgao4 I got approval from Ankit, could you help to review it? If it is OK to you, pleas merge it.
Thank you very much.

@lgao4
Copy link
Contributor

lgao4 commented Oct 20, 2025

@lgao4 I got approval from Ankit, could you help to review it? If it is OK to you, pleas merge it. Thank you very much.

I am OK for the code change. I suggest to separate the changes to three commits. They resolve the different problems.

@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_memory_corruption_issue_with_InstallAcpiTableFromAcpiSiliconHob branch from 7efe90d to 46cfb36 Compare October 20, 2025 17:48
Clearing wrong memory content after allocated memory for XSDT,
which caused AcpiSdtProtocol cannot be installed and
unexpected behavior.

According to the UEFI spec and commit message of "PCD switch to
 avoid using ACPI reclaim memory", so need to add this support in the
 InstallAcpiTableFromAcpiSiliconHob().

1. Fixed memory corruption issue in the
   InstallAcpiTableFromAcpiSiliconHob().
2. Added "PCD switch to avoid using ACPI reclaim memory" support in
   the InstallAcpiTableFromAcpiSiliconHob().

Signed-off-by: George Liao <george.liao@intel.com>
@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_memory_corruption_issue_with_InstallAcpiTableFromAcpiSiliconHob branch from 46cfb36 to 03e709f Compare October 20, 2025 17:53
Added "PublishTables()" and "SdtNotifyAcpiList()" for completing
AddTableToList behavior in the InstallAcpiTableFromAcpiSiliconHob().

Signed-off-by: George Liao <george.liao@intel.com>
Improving InitializeAcpiTableDxe() behavior.

Signed-off-by: George Liao <george.liao@intel.com>
@GeorgeLiao012
Copy link
Contributor Author

@lgao4 I got approval from Ankit, could you help to review it? If it is OK to you, pleas merge it. Thank you very much.

I am OK for the code change. I suggest to separate the changes to three commits. They resolve the different problems.

I broke the PR into the three commits and all checks have passed.
Please help to review the PR again, thank you very much.

@lgao4 lgao4 added the push Auto push patch series in PR if all checks pass label Oct 21, 2025
@mergify mergify bot added the queued label Oct 21, 2025
@mergify mergify bot merged commit 44214c0 into tianocore:master Oct 21, 2025
117 checks passed
@mergify mergify bot removed the queued label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

push Auto push patch series in PR if all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants