-
Notifications
You must be signed in to change notification settings - Fork 3k
MdeModulePkg/AcpiTableDxe:Fixed memory corruption issue #11602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MdeModulePkg/AcpiTableDxe:Fixed memory corruption issue #11602
Conversation
Pull Request Formatting Issues
Address these issues and the validation will automatically re-run when you update your pull request. |
Pull Request Formatting Issues
Address these issues and the validation will automatically re-run when you update your pull request. |
26dfb9a to
7efe90d
Compare
|
@dandanbi @LiuZhiguang001 Could you help to review this PR? Thanks. |
|
@lgao4 I got approval from Ankit, could you help to review it? If it is OK to you, pleas merge it. |
I am OK for the code change. I suggest to separate the changes to three commits. They resolve the different problems. |
7efe90d to
46cfb36
Compare
Clearing wrong memory content after allocated memory for XSDT, which caused AcpiSdtProtocol cannot be installed and unexpected behavior. According to the UEFI spec and commit message of "PCD switch to avoid using ACPI reclaim memory", so need to add this support in the InstallAcpiTableFromAcpiSiliconHob(). 1. Fixed memory corruption issue in the InstallAcpiTableFromAcpiSiliconHob(). 2. Added "PCD switch to avoid using ACPI reclaim memory" support in the InstallAcpiTableFromAcpiSiliconHob(). Signed-off-by: George Liao <george.liao@intel.com>
46cfb36 to
03e709f
Compare
Added "PublishTables()" and "SdtNotifyAcpiList()" for completing AddTableToList behavior in the InstallAcpiTableFromAcpiSiliconHob(). Signed-off-by: George Liao <george.liao@intel.com>
Improving InitializeAcpiTableDxe() behavior. Signed-off-by: George Liao <george.liao@intel.com>
I broke the PR into the three commits and all checks have passed. |
…AcpiTableFromAcpiSiliconHob
Description
How This Was Tested
SUT booting to the operation system with ACPI tables that installed in the ACPI Hob
Integration Instructions
None