[Code First] GI 11627: Add DXE_SERVICES.ADD_MEMORY_SPACEV2#11628
Closed
os-d wants to merge 7 commits into
Closed
Conversation
This adds the required markdown template for AddMemorySpaceV2. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
As part of the edk2 Code First process, this commit adds the EFI_ADD_MEMORY_SPACEV2 DXE Service definition. This function behaves exactly the same as the EFI_ADD_MEMORY_SPACE DXE Service except it takes an additional attributes parameter and sets those attributes on the newly added range. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
os-d
changed the title
Contributor
Author
|
Code First GH Issue: #11628 |
Contributor
Author
|
Note: CI will fail on this for uncrustify until tianocore/uncrustify#5 is resolved. |
As part of the edk2 Code First Process, this adds the implemenation of the new EFI_ADD_MEMORY_SPACE_V2 DXE Service. This services adds a new memory space to the GCD and sets the specified attributes on the range. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This updates MmCommunicationDxe to use the new AddMemorySpaceV2 DXE Service instead of AddMemorySpace + SetMemorySpaceAttributes. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This updates PL031RealTimeClockLib to use the new AddMemorySpaceV2 DXE Service instead of AddMemorySpace + SetMemorySpaceAttributes. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This updates KvmtoolRtcFdtClientLib to use the new AddMemorySpaceV2 DXE Service instead of AddMemorySpace + SetMemorySpaceAttributes. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This updates various modules in OvmfPkg to use the new AddMemorySpaceV2 DXE Service instead of AddMemorySpace + SetMemorySpaceAttributes. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
os-d
force-pushed
the
GI11627_addmemoryspacev2
branch
from
81b234a to
aed7f33
Compare
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
Bot
added
the
stale
|
This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the AddMemorySpaceV2 function to DXE Services. This function behaves exactly the same as
DXE_SERVICES.ADD_MEMORY_SPACE except that it takes an additional parameter, Attributes, which are the memory
attributes to be set on that range. This is equivalent to calling DXE_SERVICES.ADD_MEMORY_SPACE and then
DXE_SERVICES.SET_MEMORY_SPACE_ATTRIBUTES except that error handling is cleaner. It follows in the spirit of other proposed PI spec changes that are merging adding memory ranges with setting attributes on them.
How This Was Tested
Tested on OVMF.
Integration Instructions
Callers may use gDS->AddMemorySpaceV2() to add a memory space and set attributes on it.