Replace truetime with networktime

Author: stoyicker

eventproducer/build.gradle.kts

@@ -27,7 +27,7 @@ dependencies {
     implementation(libs.tickaroo.annotation)
     implementation(libs.tickaroo.core)
     implementation(libs.tickaroo.retrofitConverter)
-    implementation(libs.truetime)
+    implementation(libs.tidal.networktime.singletons)
 
     ksp(libs.dagger.compiler)
     kapt(libs.room.compiler)

eventproducer/src/main/kotlin/com/tidal/sdk/eventproducer/EventProducer.kt

@@ -1,6 +1,7 @@
 package com.tidal.sdk.eventproducer
 
 import android.content.Context
+import com.tidal.networktime.SNTPClient
 import com.tidal.sdk.auth.CredentialsProvider
 import com.tidal.sdk.eventproducer.di.DaggerEventsComponent
 import com.tidal.sdk.eventproducer.model.EventsConfig
@@ -43,6 +44,9 @@ class EventProducer private constructor(coroutineScope: CoroutineScope) {
     @Inject
     internal lateinit var monitoringScheduler: MonitoringScheduler
 
+    @Inject
+    internal lateinit var sntpClient: SNTPClient
+
     internal fun startOutage() {
         _outageState.value = OutageState.Outage()
     }
@@ -91,6 +95,7 @@ class EventProducer private constructor(coroutineScope: CoroutineScope) {
                         )
                 EventProducer(coroutineScope).also {
                     eventsComponent.inject(it)
+                    it.sntpClient.enableSynchronization()
                     coroutineScope.launch(Dispatchers.IO) { it.scheduler.scheduleBatchAndSend() }
                     coroutineScope.launch(Dispatchers.IO) {
                         it.monitoringScheduler.scheduleSendMonitoringInfo()

eventproducer/src/main/kotlin/com/tidal/sdk/eventproducer/di/UtilsModule.kt

@@ -1,9 +1,11 @@
 package com.tidal.sdk.eventproducer.di
 
+import com.tidal.networktime.NTPServer
+import com.tidal.networktime.SNTPClient
+import com.tidal.networktime.singletons.singleton
 import com.tidal.sdk.auth.CredentialsProvider
 import com.tidal.sdk.eventproducer.model.EventsConfigProvider
 import com.tidal.sdk.eventproducer.utils.HeadersUtils
-import com.tidal.sdk.eventproducer.utils.TrueTimeWrapper
 import dagger.Module
 import dagger.Provides
 import dagger.Reusable
@@ -15,10 +17,10 @@ internal class UtilsModule {
     fun provideHeadersUtils(
         configProvider: EventsConfigProvider,
         credentialsProvider: CredentialsProvider,
-        trueTimeWrapper: TrueTimeWrapper,
-    ) = HeadersUtils(configProvider.config.appVersion, credentialsProvider, trueTimeWrapper)
+        sntpClient: SNTPClient,
+    ) = HeadersUtils(configProvider.config.appVersion, credentialsProvider, sntpClient)
 
     @Provides
     @Reusable
-    fun provideTrueTimeWrapper() = TrueTimeWrapper()
+    fun provideSNTPClient() = SNTPClient(NTPServer("time.google.com")).singleton
 }

eventproducer/src/main/kotlin/com/tidal/sdk/eventproducer/utils/HeadersUtils.kt

@@ -1,6 +1,7 @@
 package com.tidal.sdk.eventproducer.utils
 
 import android.os.Build
+import com.tidal.networktime.SNTPClient
 import com.tidal.sdk.auth.CredentialsProvider
 import com.tidal.sdk.eventproducer.model.ConsentCategory
 import javax.inject.Inject
@@ -19,7 +20,7 @@ internal const val DEVICE_VENDOR_KEY = "device-vendor"
 internal class HeadersUtils @Inject constructor(
     private val appVersion: String,
     private val credentialsProvider: CredentialsProvider,
-    private val trueTimeWrapper: TrueTimeWrapper,
+    private val sntpClient: SNTPClient,
 ) {
     fun getEventHeaders(
         defaultHeaders: Map<String, String>,
@@ -32,7 +33,7 @@ internal class HeadersUtils @Inject constructor(
     ): Map<String, String> {
         val deviceModel = Build.MODEL
         val deviceVendor = Build.MANUFACTURER
-        val sentTimestamp = trueTimeWrapper.currentTimeMillis.toString()
+        val sentTimestamp = sntpClient.ntpOrLocalClockTime.inWholeMilliseconds.toString()
         val osName = "Android"
         val osVersion = Build.VERSION.SDK_INT.toString()
         val headers = mutableMapOf<String, String>()

eventproducer/src/main/kotlin/com/tidal/sdk/eventproducer/utils/TrueTimeWrapper.kt

@@ -1,8 +1,11 @@
 package com.tidal.sdk.eventproducer.utils
 
+import com.tidal.networktime.SNTPClient
 import com.tidal.sdk.eventproducer.model.Result
 import com.tidal.sdk.eventproducer.model.failure
 import com.tidal.sdk.eventproducer.model.success
+import kotlin.time.Duration
+import kotlin.time.Duration.Companion.milliseconds
 
 @Suppress("TooGenericExceptionCaught", "SwallowedException")
 internal suspend fun <T> safeRequest(block: suspend () -> T): Result<T> {
@@ -12,3 +15,6 @@ internal suspend fun <T> safeRequest(block: suspend () -> T): Result<T> {
         failure()
     }
 }
+
+internal val SNTPClient.ntpOrLocalClockTime: Duration
+    get() = epochTime ?: System.currentTimeMillis().milliseconds

eventproducer/src/main/kotlin/com/tidal/sdk/eventproducer/utils/Utils.kt

@@ -3,11 +3,11 @@ package com.tidal.eventproducer.utils
 import assertk.assertThat
 import assertk.assertions.containsAll
 import com.tidal.eventproducer.fakes.FakeCredentialsProvider
+import com.tidal.networktime.SNTPClient
 import com.tidal.sdk.eventproducer.utils.APP_VERSION_KEY
 import com.tidal.sdk.eventproducer.utils.CLIENT_ID_KEY
 import com.tidal.sdk.eventproducer.utils.HeadersUtils
 import com.tidal.sdk.eventproducer.utils.OS_NAME_KEY
-import com.tidal.sdk.eventproducer.utils.TrueTimeWrapper
 import io.mockk.mockk
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Test
@@ -17,7 +17,7 @@ class HeadersUtilsTest {
     private val headerUtils = HeadersUtils(
         "",
         FakeCredentialsProvider(),
-        mockk<TrueTimeWrapper>(),
+        mockk<SNTPClient>(),
     )
 
     @Test

eventproducer/src/test/kotlin/com/tidal/eventproducer/utils/HeadersUtilsTest.kt

@@ -21,6 +21,7 @@ slf4j-api = "2.0.12"
 tickaroo = "0.8.13"
 tidal-androidx-media = "1.1.1.2"
 plugins-tidal = "unspecified"
+tidal-networktime = "1.1.1"
 
 [libraries]
 plugin-kotlin-android = { group = "org.jetbrains.kotlin", name = "kotlin-gradle-plugin", version.ref = "kotlin" }
@@ -55,7 +56,6 @@ gson = "com.google.code.gson:gson:2.9.0"
 kotlin-reflect = { module = "org.jetbrains.kotlin:kotlin-reflect", version.ref = "kotlin" }
 kotlin-logging = { module = "io.github.oshai:kotlin-logging-jvm", version.ref = "kotlin-logging" }
 slf4j-api = { module = "org.slf4j:slf4j-api", version.ref = "slf4j-api" }
-truetime = "com.github.instacart.truetime-android:library-extension-rx:3.5"
 
 # Moshi
 moshi = { module = "com.squareup.moshi:moshi", version.ref ="moshi"}
@@ -112,6 +112,9 @@ tidal-exoPlayer-hls = { module = "com.tidal.androidx.media3:media3-exoplayer-hls
 tidal-exoPlayer-extension-flac = { module = "com.tidal.androidx.media3:media3-flac", version.ref = "tidal-androidx-media" }
 tidal-exoPlayer-extension-okhttp = { module = "com.tidal.androidx.media3:media3-datasource-okhttp", version.ref = "tidal-androidx-media" }
 
+tidal-networktime = { module = "com.tidal.networktime:networktime", version.ref = "tidal-networktime" }
+tidal-networktime-singletons = { module = "com.tidal.networktime:networktime-singletons", version.ref = "tidal-networktime" }
+
 # Security
 androidx-security-crypto = { module = "androidx.security:security-crypto", version = "1.0.0" }
 

gradle/libs.versions.toml

@@ -19,19 +19,19 @@ The Player module encapsulates the playback functionality of TIDAL media product
 
 ### Installation
 
-1. We are using the [TrueTime library](https://github.com/instacart/truetime-android) internally, so you need to add the following to your repositories list:
+1. Add the dependency to your `build.gradle.kts` file.
 ```kotlin
-maven {
-    url = uri("https://jitpack.io")
+repositories {
+    mavenCentral()
 }
 ```
 
-2. Add the dependency to your `build.gradle.kts` file.
 ```kotlin
 dependencies {
     implementation("com.tidal.sdk:player:<VERSION>")
 }
 ```
+
 ### Playing a TIDAL track
 The Player depends on the [Auth](https://github.com/tidal-music/tidal-sdk-android/blob/main/auth/README.md) and [EventProducer](https://github.com/tidal-music/tidal-sdk-android/tree/main/eventproducer) modules for authentication and event reporting handling. For detailed instructions on how to set them up, please refer to their guide. 
 

player/README.md

@@ -35,5 +35,4 @@ dependencies {
     implementation(platform(libs.androidx.compose.bom))
     implementation(libs.androidx.activity.compose)
     implementation(libs.androidx.compose.material3)
-    implementation(libs.truetime)
 }