Skip to content

MF-171: Add action count assertions to PlayLog tests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: jantonio/playlog_test_24
Choose a base branch
from
Open

MF-171: Add action count assertions to PlayLog tests #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2e3ade
Add PlayLog test 23
stoyicker Jun 28, 2024
1e2a813
Add PlayLog test 24
stoyicker Jun 28, 2024
60b5c12
MF-171: Add action array size assertions
stoyicker Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions player/src/androidTest/kotlin/com/tidal/sdk/player/playlog/SingleMediaProductPlayLogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ internal class SingleMediaProductPlayLogTest {
1.seconds.inWholeMilliseconds
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
}
true
Expand Down Expand Up @@ -303,6 +304,7 @@ internal class SingleMediaProductPlayLogTest {
val perfectResumeTimestamp = stopAction.timestamp
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
}
true
Expand Down Expand Up @@ -357,6 +359,7 @@ internal class SingleMediaProductPlayLogTest {
val perfectResumeTimestamp = stopAction.timestamp
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
}
true
Expand Down Expand Up @@ -413,6 +416,7 @@ internal class SingleMediaProductPlayLogTest {
val perfectResumeTimestamp = stopAction.timestamp
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
}
true
Expand Down Expand Up @@ -469,6 +473,7 @@ internal class SingleMediaProductPlayLogTest {
val perfectResumeTimestamp = stopAction.timestamp
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
}
true
Expand Down Expand Up @@ -553,6 +558,7 @@ internal class SingleMediaProductPlayLogTest {
perfectSecondResumeTimestamp - 500,
perfectSecondResumeTimestamp + 500,
)
assertThat(size()).isEqualTo(4)
}
}
true
Expand Down Expand Up @@ -631,6 +637,7 @@ internal class SingleMediaProductPlayLogTest {
perfectSecondResumeTimestamp - 500,
perfectSecondResumeTimestamp + 500,
)
assertThat(size()).isEqualTo(4)
}
}
true
Expand Down Expand Up @@ -819,6 +826,7 @@ internal class SingleMediaProductPlayLogTest {
val perfectResumeTimestamp = stopAction.timestamp
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
}
true
Expand Down Expand Up @@ -882,6 +890,7 @@ internal class SingleMediaProductPlayLogTest {
.isAssetPositionEqualTo(MEDIA_PRODUCT_DURATION_SECONDS)
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
},
1 to {
Expand Down
107 changes: 107 additions & 0 deletions player/src/androidTest/kotlin/com/tidal/sdk/player/playlog/TwoMediaProductsPlayLogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ internal class TwoMediaProductsPlayLogTest {
.isAssetPositionEqualTo(MEDIA_PRODUCT_1_DURATION_SECONDS)
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
},
1 to {
Expand Down Expand Up @@ -618,6 +619,7 @@ internal class TwoMediaProductsPlayLogTest {
perfectSecondResumeTimestamp - 500,
perfectSecondResumeTimestamp + 500,
)
assertThat(size()).isEqualTo(4)
}
},
1 to {
Expand Down Expand Up @@ -647,6 +649,7 @@ internal class TwoMediaProductsPlayLogTest {
assertThat(startAction.assetPositionSeconds).isAssetPositionEqualTo(58.0)
assertThat(startAction.timestamp)
.isBetween(perfectResumeTimestamp - 500, perfectResumeTimestamp + 500)
assertThat(size()).isEqualTo(2)
}
},
1 to {
Expand All @@ -659,4 +662,108 @@ internal class TwoMediaProductsPlayLogTest {
},
)
}

@Suppress("CyclomaticComplexMethod")
@Test
fun playSequentiallyWithoutRepeatOne() = runTest {
val gson = Gson()
val payloadCaptor = argumentCaptor<String>()

player.playbackEngine.load(mediaProduct1)
player.playbackEngine.play()
withContext(Dispatchers.Default.limitedParallelism(1)) {
delay(2.seconds)
while (player.playbackEngine.assetPosition < 2) {
delay(10.milliseconds)
}
player.playbackEngine.load(mediaProduct2)
player.playbackEngine.play()
delay(1.seconds)
while (player.playbackEngine.assetPosition < 1) {
delay(10.milliseconds)
}
player.playbackEngine.reset()
}

eventReporterCoroutineScope.advanceUntilIdle()

eventReporterCoroutineScope.advanceUntilIdle()
verify(eventSender, times(2)).sendEvent(
eq("playback_session"),
eq(ConsentCategory.NECESSARY),
payloadCaptor.capture(),
eq(emptyMap()),
)
payloadCaptor.allValues.map {
gson.fromJson(it, JsonObject::class.java)["payload"].asJsonObject
}.combinedPassAllOf(
1 to {
assertThat(get("startAssetPosition").asDouble).isAssetPositionEqualTo(0.0)
assertThat(get("endAssetPosition").asDouble).isAssetPositionEqualTo(2.0)
assertThat(get("actualProductId")?.asString).isEqualTo(mediaProduct1.productId)
assertThat(get("sourceType")?.asString).isEqualTo(mediaProduct1.sourceType)
assertThat(get("sourceId")?.asString).isEqualTo(mediaProduct1.sourceId)
assertThat(get("actions").asJsonArray).isEmpty()
},
1 to {
assertThat(get("startAssetPosition").asDouble).isAssetPositionEqualTo(0.0)
assertThat(get("endAssetPosition").asDouble).isAssetPositionEqualTo(1.0)
assertThat(get("actualProductId")?.asString).isEqualTo(mediaProduct2.productId)
assertThat(get("sourceType")?.asString).isEqualTo(mediaProduct2.sourceType)
assertThat(get("sourceId")?.asString).isEqualTo(mediaProduct2.sourceId)
assertThat(get("actions").asJsonArray).isEmpty()
},
)
}

@Suppress("CyclomaticComplexMethod")
@Test
fun playTwiceWithoutRepeatOne() = runTest {
val gson = Gson()
val payloadCaptor = argumentCaptor<String>()

player.playbackEngine.load(mediaProduct1)
player.playbackEngine.play()
withContext(Dispatchers.Default.limitedParallelism(1)) {
delay(2.seconds)
while (player.playbackEngine.assetPosition < 2) {
delay(10.milliseconds)
}
player.playbackEngine.load(mediaProduct1)
player.playbackEngine.play()
delay(1.seconds)
while (player.playbackEngine.assetPosition < 1) {
delay(10.milliseconds)
}
player.playbackEngine.reset()
}

eventReporterCoroutineScope.advanceUntilIdle()
verify(eventSender, times(2)).sendEvent(
eq("playback_session"),
eq(ConsentCategory.NECESSARY),
payloadCaptor.capture(),
eq(emptyMap()),
)
payloadCaptor.allValues.map {
gson.fromJson(it, JsonObject::class.java)["payload"].asJsonObject
}.combinedPassAllOf(
1 to {
assertThat(get("startAssetPosition").asDouble).isAssetPositionEqualTo(0.0)
assertThat(get("endAssetPosition").asDouble).isAssetPositionEqualTo(2.0)
assertThat(get("actualProductId")?.asString).isEqualTo(mediaProduct1.productId)
assertThat(get("sourceType")?.asString).isEqualTo(mediaProduct1.sourceType)
assertThat(get("sourceId")?.asString).isEqualTo(mediaProduct1.sourceId)
assertThat(get("actions").asJsonArray).isEmpty()
},
1 to {
assertThat(get("startAssetPosition").asDouble).isAssetPositionEqualTo(0.0)
assertThat(get("endAssetPosition").asDouble).isAssetPositionEqualTo(1.0)
assertThat(get("actualProductId")?.asString).isEqualTo(mediaProduct1.productId)
assertThat(get("sourceType")?.asString).isEqualTo(mediaProduct1.sourceType)
assertThat(get("sourceId")?.asString).isEqualTo(mediaProduct1.sourceId)
assertThat(get("actions").asJsonArray).isEmpty()
},
)
}
}