don't use is_installed() AND check_installed()

Author: EmilHvitfeldt

R/misc.R

@@ -67,13 +67,14 @@ as_factor_from_class_pred <- function(x, call = caller_env()) {
     return(x)
   }
 
-  if (!is_installed("probably")) {
-    check_installed(
-      pkg = "probably",
-      reason = cli::format_inline("\nA {.cls class_pred} input was detected and {.pkg probably} is required to convert {.cls class_pred} to {.cls factor}."),
-      call = call
-    )
-  }
+  check_installed(
+    pkg = "probably",
+    reason = cli::format_inline(
+      "\nA {.cls class_pred} input was detected and {.pkg probably} is required to convert {.cls class_pred} to {.cls factor}."
+    ),
+    call = call
+  )
+
   probably::as.factor(x)
 }
 

tests/testthat/test-misc.R

@@ -368,16 +368,4 @@ test_that("work with class_pred input", {
 
   fct_estimate <- two_class_example$predicted
   fct_estimate[2] <- NA
-
-  local_mocked_bindings(
-    .package = "rlang",
-    detect_installed = function(pkg, ...) {
-      FALSE
-    }
-  )
-
-  expect_snapshot(
-    error = TRUE,
-    accuracy_vec(fct_truth, cp_estimate)
-  )
 })