Misleading "Error processing duckplyr query with DuckDB"

[maelle]

I find it confusing the message says "error" while there is no actual R error.

[maelle]

Especially because of the red color.

I am obviously aware of fallbacks but still thought I had done something wrong when I saw the red word "Error". 😂

[krlmlr]

Do you remember the context?

[maelle]

Yes! But I agree this issue is poorly written, sorry about that.

When you get a fallback, at least last time I tried (for the blog post) I got a message in red that said "Error processing duckplyr query with DuckDB". But it wasn't an actual error since there was a fallback. Despite knowing about fallbacks, I was first taken aback and thought it was an error.

Now I should try and find a reprex.

[maelle]

duckplyr/R/relational.R

Line 71 in 10a2f40

rlang::cnd_signal(rlang::message_cnd(message = "Error processing duckplyr query with DuckDB, falling back to dplyr.", parent = out))

[maelle]

I'd suggest rephrasing so that error does not come first. Maybe just switching the two parts of the sentence. I imagine other users might have a strong reaction to a message starting with "Error" 😂

[krlmlr]

Good idea, let's call it "Could not process duckplyr query with DuckDB" or similar.

[moodymudskipper]

When falling back to dplyr 'duckplyr' prints a message "Error processing duckplyr query with DuckDB, falling back to dplyr.".

It is not an error however so this is confusing to the user. We want to use instead something like "Could not process duckplyr query with DuckDB" or similar.