We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe what's wrong
current CI script has a bug
proton/tests/stream/ci_runner.py
Lines 232 to 238 in ccb6f3d
the pr_number read from env but we shall stick to GITHUB_REF instead GITHUB_REF_NAME ref
GITHUB_REF
GITHUB_REF_NAME
3 results - 1 file tests/stream/ci_runner.py: 209 if run_mode == "github": 210: pr_number = os.getenv("GITHUB_REF_NAME", pr_number) 211 commit_sha = os.getenv("GITHUB_SHA", commit_sha) 383 if run_mode == "github": 384: pr_number = os.getenv("GITHUB_REF_NAME", "0") 385 commit_sha = os.getenv("GITHUB_SHA", "0") 427 os_info = os.getenv("RUNNER_OS", "Linux") 428: pr_number = os.getenv("GITHUB_REF_NAME", "0") 429 commit_sha = os.getenv("GITHUB_SHA", "0")
def upload_proton_logs(s3_client, proton_log_folder, pr_number="0", commit_sha=""): s3_proton_log_folder = ( f"reports/proton/tests/CI/{pr_number}/{commit_sha}/proton_logs" ) proton_log_url = s3_client.upload_test_folder_to_s3( proton_log_folder, s3_proton_log_folder ) logging.info("Search result in url %s", proton_log_url) return proton_log_url
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe what's wrong
current CI script has a bug
proton/tests/stream/ci_runner.py
Lines 232 to 238 in ccb6f3d
the pr_number read from env but we shall stick to
GITHUB_REF
insteadGITHUB_REF_NAME
refThe text was updated successfully, but these errors were encountered: