Skip to content

CI: migrate to another s3 bucket #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yokofly opened this issue Apr 14, 2025 · 0 comments
Open

CI: migrate to another s3 bucket #933

yokofly opened this issue Apr 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@yokofly
Copy link
Collaborator

yokofly commented Apr 14, 2025

Describe what's wrong

  1. prebuilt binary pull(v8) && push(macOS binary)
  2. c-cache
  3. CI report log push

current CI script has a bug

proton_log_folder_url = upload_proton_logs(
s3_helper,
proton_log_folder,
pr_number,
commit_sha,
)
print(f"::notice ::Proton server log url: {proton_log_folder_url}")

the pr_number read from env but we shall stick to GITHUB_REF instead GITHUB_REF_NAME ref

3 results - 1 file

tests/stream/ci_runner.py:
  209      if run_mode == "github":
  210:         pr_number = os.getenv("GITHUB_REF_NAME", pr_number)
  211          commit_sha = os.getenv("GITHUB_SHA", commit_sha)

  383      if run_mode == "github":
  384:         pr_number = os.getenv("GITHUB_REF_NAME", "0")
  385          commit_sha = os.getenv("GITHUB_SHA", "0")

  427      os_info = os.getenv("RUNNER_OS", "Linux")
  428:     pr_number = os.getenv("GITHUB_REF_NAME", "0")
  429      commit_sha = os.getenv("GITHUB_SHA", "0")

def upload_proton_logs(s3_client, proton_log_folder, pr_number="0", commit_sha=""):
    s3_proton_log_folder = (
        f"reports/proton/tests/CI/{pr_number}/{commit_sha}/proton_logs"
    )
    proton_log_url = s3_client.upload_test_folder_to_s3(
        proton_log_folder, s3_proton_log_folder
    )
    logging.info("Search result in url %s", proton_log_url)
    return proton_log_url
@yokofly yokofly added the bug Something isn't working label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant