Update KMS client library #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @chuckx, thanks for taking a look at this. I wanted to say that I'm happy to do further work on this PR if it's necessary. I'm not familiar with Bazel or Copybara, and I'm reasonably new to Go, so any feedback no-matter how minor is welcome. Thanks again. |
Contributor
|
Thanks for the PR. I'll be taking a closer look at this later this week. |
Author
|
Did you have any initial thoughts on this @chuckx? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Tink extension currently depends on the deprecated
google.golang.org/api/cloudkms/v1package for its KMS client library.This PR updates the KMS client library to use the recommended
cloud.google.com/go/kms/apiv1package instead.