Skip to content

cluster: if not found via OwnerReference, look for Cluster via standard label cluster.x-k8s.io/cluster-name on TinkerbellCluster #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

cluster: if not found via OwnerReference, look for Cluster via standard label cluster.x-k8s.io/cluster-name on TinkerbellCluster #501

merged 1 commit into from
Sep 29, 2025
+21 −1

Conversation

@rpardini
Copy link
Member

  • if found via label, set actual OwnerReference
  • this is done by using CAPI-core's util.GetClusterFromMetadata()
  • this makes using CAPT in mixed-infrastructure Clusters much easier

@rpardini
cluster: if not found via OwnerReference, look for Cluster via standa…
7700b08 
…rd label cluster.x-k8s.io/cluster-name on TinkerbellCluster

- if found via label, set actual OwnerReference
- this is done by using CAPI-core's util.GetClusterFromMetadata()
- this makes using CAPT in mixed-infrastructure Clusters much easier

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
jacobweinstock
jacobweinstock approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rpardini!

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Sep 29, 2025
@mergify mergify bot added the queued label Sep 29, 2025
mergify bot added a commit that referenced this pull request Sep 29, 2025
@mergify
Merge of #501
2bb57d4
@mergify mergify bot mentioned this pull request Sep 29, 2025
Closed
16 tasks
@mergify mergify bot merged commit c02d6fb into tinkerbell:main Sep 29, 2025
12 checks passed
@mergify mergify bot removed the queued label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobweinstock jacobweinstock jacobweinstock approved these changes

Assignees

No one assigned

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rpardini @jacobweinstock