Skip to content

PropertyGraphSail: Speed up xPx and xPO queries #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PropertyGraphSail: Speed up xPx and xPO queries #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...ail/src/main/java/com/tinkerpop/blueprints/oupls/sail/pg/PropertyGraphSailConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,14 +812,13 @@ private CloseableIteration<Statement, SailException> getStatements_xPO(final URI
if (null == value) {
return new StatementIteration();
} else {
// TODO: lookup matching vertices and edges faster using indices
String key = keyFromPredicate(predicate);
Source<Vertex> vertices = new Source<Vertex>(
context.graph.getVertices().iterator(),
context.graph.getVertices(key, value).iterator(),
vertexPropertiesWithKeyAndValue(key, predicate, value, (Literal) object));
if (firstClassEdges) {
Source<Edge> edges = new Source<Edge>(
context.graph.getEdges().iterator(),
context.graph.getEdges(key, value).iterator(),
edgePropertiesWithKeyAndValue(key, predicate, value, (Literal) object));
return new StatementIteration(vertices, edges);
} else {
Expand Down Expand Up @@ -887,14 +886,13 @@ private CloseableIteration<Statement, SailException> getStatements_xPx(final URI
Source<Edge> edges = new Source<Edge>(edgeIterator, tails);
return new StatementIteration(edges);
} else if (isPropertyPredicate(predicate)) {
// TODO: find elements faster using indices
String key = keyFromPredicate(predicate);
Source<Vertex> vertices = new Source<Vertex>(
context.graph.getVertices().iterator(),
context.graph.query().has(key).vertices().iterator(),
vertexPropertiesWithKey(key, predicate));
if (firstClassEdges) {
Source<Edge> edges = new Source<Edge>(
context.graph.getEdges().iterator(),
context.graph.query().has(key).edges().iterator(),
edgePropertiesWithKey(key, predicate));
return new StatementIteration(vertices, edges);
} else {
Expand Down