Skip to content

machine/rp2: merge common usb code #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

machine/rp2: merge common usb code #4856

merged 2 commits into from
Apr 15, 2025

Conversation

mikesmitty
Copy link
Contributor

Originating from a comment by @eliasnaur on #4850, this merges the shared components of the rp2 USB stacks

eliasnaur
eliasnaur approved these changes Apr 12, 2025
View reviewed changes
Copy link
Contributor

@eliasnaur eliasnaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you. I verified that machine_rp2_usb.go is a straightforward copy of code common to the machine_rp2xxx_usb.go files.

@deadprogram
Copy link
Member

Thank you very much for splitting out this PR and for the excellent work overall @mikesmitty this is very exciting!

Also thanks for the detailed reviews @eliasnaur ⭐

Now squash/merging.

@deadprogram deadprogram merged commit 133e32c into tinygo-org:dev Apr 15, 2025
18 checks passed
@deadprogram deadprogram mentioned this pull request Apr 15, 2025
Merged
@mikesmitty mikesmitty deleted the ms/merge-rp2-usb branch April 15, 2025 13:25
@mikesmitty
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasnaur eliasnaur eliasnaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikesmitty @deadprogram @eliasnaur