Skip to content

Conversation

@abhinavgandham
Copy link

@abhinavgandham abhinavgandham commented Sep 10, 2025

Ticket: DOC-3274

Changes:

  • Fixed curl commands to use a single slash instead of double slash and modified docker compose yaml files to use latest target path in the Hyperlinking, Image Proxy, and Spelling docker guides. Also added a note underneath the docker compose yaml code.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

abhinavgandham and others added 6 commits September 10, 2025 15:53
…-service-installation.adoc

Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
…ervice-installation.adoc

Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
…-installation.adoc

Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
@frossi933
Copy link
Contributor

frossi933 commented Sep 18, 2025

The lines at docker-compose.yaml files are not aligned correctly, for example: https://github.com/tinymce/tinymce-docs/pull/3859/files#diff-234044e9e949987ad72a2ccde75c2bcc202458cbf7bb216859827077532aab47L129

  • Correct yaml alignments

@frossi933
Copy link
Contributor

frossi933 commented Sep 18, 2025

Starting from the recently released version of Image Proxy service (2.111.12), the target here should point to /app/application.conf as the rest of the services

  • Update target for Image Proxy docs
  • Add Note specifying the starting version for this breaking change
  • Update docker compose up logs for Image Proxy Service

…snippets and updated image proxy yml code with the latest target path.
Copy link
Contributor

@frossi933 frossi933 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit 4c7bf3a into tinymce/7 Sep 23, 2025
5 checks passed
@kemister85 kemister85 deleted the hotfix/7/DOC-3274 branch September 23, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants