-
Notifications
You must be signed in to change notification settings - Fork 61
Add pyproject.toml #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml #464
Conversation
The failing CI will be resolved after #465 is merged; we will wait to review/merge until that is merged. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 63.55% 63.56% +0.01%
==========================================
Files 27 27
Lines 3844 3859 +15
==========================================
+ Hits 2443 2453 +10
- Misses 1401 1406 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for adding this! Happy for this to be merged
Can we get this merged prior to the v1.6 release? |
Not sure whether to merge this into |
Linting results by Pylint:Your code has been rated at 8.31/10 (previous run: 8.31/10, +0.00) |
moving back to draft due to some issues with the processing of the version. |
Ok all issues here have been fixed. CI issue is related to #276 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, I tested it locally and the install works and version number displays correctly
# Conflicts: # tobac/__init__.py
Resolves #442 and adds a (fairly basic)
pyproject.toml
to tobac.Note that this is proposed as a merge to main.