Skip to content

Conversation

freemansw1
Copy link
Member

@freemansw1 freemansw1 commented Nov 1, 2024

Resolves #442 and adds a (fairly basic) pyproject.toml to tobac.

Note that this is proposed as a merge to main.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added the enhancement Addition of new features, or improved functionality of existing features label Nov 1, 2024
@freemansw1 freemansw1 self-assigned this Nov 1, 2024
@freemansw1
Copy link
Member Author

The failing CI will be resolved after #465 is merged; we will wait to review/merge until that is merged.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.56%. Comparing base (f0240d4) to head (b270b29).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
tobac/__init__.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   63.55%   63.56%   +0.01%     
==========================================
  Files          27       27              
  Lines        3844     3859      +15     
==========================================
+ Hits         2443     2453      +10     
- Misses       1401     1406       +5     
Flag Coverage Δ
unittests 63.56% <68.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding this! Happy for this to be merged

@w-k-jones
Copy link
Member

Can we get this merged prior to the v1.6 release?

@freemansw1
Copy link
Member Author

Not sure whether to merge this into main or to merge this into the dev branch, but ready for re-review @w-k-jones and @JuliaKukulies

@freemansw1 freemansw1 requested a review from w-k-jones July 16, 2025 14:46
Copy link

github-actions bot commented Jul 16, 2025

Linting results by Pylint:

Your code has been rated at 8.31/10 (previous run: 8.31/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the main branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@freemansw1 freemansw1 mentioned this pull request Jul 16, 2025
4 tasks
@freemansw1
Copy link
Member Author

moving back to draft due to some issues with the processing of the version.

@freemansw1 freemansw1 marked this pull request as draft July 16, 2025 18:18
@freemansw1 freemansw1 marked this pull request as ready for review July 17, 2025 21:24
@freemansw1
Copy link
Member Author

Ok all issues here have been fixed. CI issue is related to #276 .

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, I tested it locally and the install works and version number displays correctly

@freemansw1
Copy link
Member Author

I think this might fix #520, so I'm rerunning tests. If so, I will merge per #521 .

@freemansw1 freemansw1 merged commit eac0cad into tobac-project:main Sep 12, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Addition of new features, or improved functionality of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pyproject.toml for package setup

2 participants