Skip to content

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Apr 7, 2025

Example tracking MCSs in global km-scale model data based on the MCSMIP protocol. This example uses remotely accessible ICON model data from MPI

Note: this PR is based on #489 , so should wait until that is merged before merging

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones self-assigned this Apr 7, 2025
@w-k-jones w-k-jones added the documentation Updates and improvements to documentation and examples label Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.52%. Comparing base (b2d23ff) to head (a5010ca).
⚠️ Report is 68 commits behind head on RC_v1.6.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.6.x     #492   +/-   ##
==========================================
  Coverage      63.52%   63.52%           
==========================================
  Files             27       27           
  Lines           3836     3836           
==========================================
  Hits            2437     2437           
  Misses          1399     1399           
Flag Coverage Δ
unittests 63.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Apr 7, 2025

Linting results by Pylint:

Your code has been rated at 8.21/10 (previous run: 8.21/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.6.0 branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@w-k-jones w-k-jones marked this pull request as ready for review June 6, 2025 11:47
@w-k-jones w-k-jones changed the base branch from RC_v1.6.x to main June 6, 2025 11:48
@w-k-jones w-k-jones changed the base branch from main to RC_v1.6.x June 6, 2025 11:48
@w-k-jones
Copy link
Member Author

Changing to ready to review now that v1.6 is released

@freemansw1 freemansw1 self-requested a review July 9, 2025 18:19
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an absolutely phenomenal example. Great work, @w-k-jones .

@JuliaKukulies
Copy link
Member

Super nice example! I think this one can be merged in our new release candidate, right? @freemansw1 @w-k-jones

@w-k-jones
Copy link
Member Author

Thanks @JuliaKukulies and @freemansw1 , I'll merge into RC_v1.6.x

@w-k-jones w-k-jones merged commit 9da0f65 into tobac-project:RC_v1.6.x Aug 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Updates and improvements to documentation and examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants