-
Notifications
You must be signed in to change notification settings - Fork 60
Add new 3D blob tracking example #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new 3D blob tracking example #493
Conversation
…-3 for 3D visualization
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.6.0 #493 +/- ##
=============================================
+ Coverage 59.14% 59.61% +0.46%
=============================================
Files 25 25
Lines 3892 3937 +45
=============================================
+ Hits 2302 2347 +45
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Linting results by Pylint:Your code has been rated at 8.31/10 (previous run: 8.31/10, +0.00) |
Hi @fsenf, could you please review this PR when you have time? |
@Sven-248 : Thank you for this contribution! I can see that most for our examples were slightly modified. I guess this comes from black changing the quotation marks. Was this indented? |
Yes, I ran Black formatting on all Jupyter Notebooks so the formatting is consistent. |
Hej @Sven-248 , I made some updates:
Could please consider the following:
|
OK, rendering does not work properly: https://tobac--493.org.readthedocs.build/en/493/examples/Basics/Idealized-Case-3_Tracking-of-a-Test-Blob-in-3D.html Extra items would be:
|
de83072
to
ca84797
Compare
Closing this PR due to merge conflicts that are easier to resolve in a fresh branch. |
This PR introduces a new example showcasing 3D blob tracking (#478). In addition, the following updates have been made:
New example added: A new example for generating and tracking 3D blobs has been added to the example folder
Environment update: The environment-examples.yml file has been updated to include any necessary dependencies related to the new example
Test function: A new test function has been added to tobac/testing.py to create a 3D blob
Minor code adjustments: Added black formatting to jupyter notebooks
Have you followed our guidelines in CONTRIBUTING.md?
Have you self-reviewed your code and corrected any misspellings?
Have you written documentation that is easy to understand?
Have you written descriptive commit messages?
Have you added NumPy docstrings for newly added functions?
Have you formatted your code using black?
If you have introduced a new functionality, have you added adequate unit tests?
Have all tests passed in your local clone?
If you have introduced a new functionality, have you added an example notebook?
Have you kept your pull request small and limited so that it is easy to review?
Have the newest changes from this branch been merged?